bump executing to 2.2.0 #39602
Open
bump executing to 2.2.0 #39602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's in particular needed to fix ipython error handling with Python 3.13 see sagemath#39591#issuecomment-2685649032 by Tobias Diez
|
@EmmanuelCharpentier - please review |
|
@jhpalmieri - please review |
|
This builds for me with Python 3.12 and 3.13 on OS X, and it fixes some doctest failures. How is it on linux? |
|
Le jeudi 27 février 2025 à 10:12 -0800, John H. Palmieri a écrit :
This builds for me with Python 3.12 and 3.13 on OS X, and it fixes
some doctest failures. How is it on linux?
—
Reply to this email directly, view it on GitHub [1], or unsubscribe
[2].
You are receiving this because you were mentioned.Message ID:
***@***.***>
jhpalmierijhpalmieri
left a comment (sagemath/sage#39602) [1]
This builds for me with Python 3.12 and 3.13 on OS X, and it fixes
some doctest failures. How is it on linux?
Ongoing... allow for a couple hours.
--
Emmanuel Charpentier
—
Reply to this email directly, view it on GitHub [1], or unsubscribe
[2].
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
It's in distros, e.g. Gentoo has it, without any patches. It works on Gentoo for sure. |
|
With both 39602 and 39571, but without --enable-system-site-packages, building from clean stage (make distclean) fails :
========================================================================
Error building Sage.
The following package(s) may have failed to build (not necessarily
during this run of 'make all-start'):
* package: cffi-1.15.1
last build time: 27 févr. 19:21
log file: /usr/local/sage-10/logs/pkgs/cffi-1.15.1.log
* package: pillow-10.1.0
last build time: 27 févr. 19:21
log file: /usr/local/sage-10/logs/pkgs/pillow-10.1.0.log
========================================================================
Is it worth retrying *with* --enable-system-packages ?
…--
Emmanuel Charpentier
----- Mail original -----
De: "Dima Pasechnik" ***@***.***>
À: "sagemath/sage" ***@***.***>
Cc: "EmmanuelCharpentier" ***@***.***>, "Mention" ***@***.***>
Envoyé: Jeudi 27 Février 2025 19:02:56
Objet: Re: [sagemath/sage] bump executing to 2.2.0 (PR #39602)
@jhpalmieri - please review
—
Reply to this email directly, view it on GitHub , or unsubscribe .
You are receiving this because you were mentioned. Message ID:
<sagemath/sage/pull/39602/c2688713040 @ github . com>
dimpasedimpase left a comment (sagemath/sage#39602)
@jhpalmieri - please review
—
Reply to this email directly, view it on GitHub , or unsubscribe .
You are receiving this because you were mentioned. Message ID:
<sagemath/sage/pull/39602/c2688713040 @ github . com>
|
|
Documentation preview for this PR (built with commit 24a418e; changes) is ready! 🎉 |
|
With 39602, 39571 AND --enable-system-site-packages, after make-distclean,
the compilation of pillow fails (log enclosed).
…--
Emmanuel Charpentier
----- Mail original -----
De: "emm charpentier" ***@***.***>
À: "sagemath/sage" ***@***.***>
Cc: "Mention" ***@***.***>, "sagemath/sage" ***@***.***>
Envoyé: Jeudi 27 Février 2025 19:36:14
Objet: Re: [sagemath/sage] bump executing to 2.2.0 (PR #39602)
With both 39602 and 39571, but without --enable-system-site-packages,
building from clean stage (make distclean) fails :
========================================================================
Error building Sage.
The following package(s) may have failed to build (not necessarily
during this run of 'make all-start'):
* package: cffi-1.15.1
last build time: 27 févr. 19:21
log file: /usr/local/sage-10/logs/pkgs/cffi-1.15.1.log
* package: pillow-10.1.0
last build time: 27 févr. 19:21
log file: /usr/local/sage-10/logs/pkgs/pillow-10.1.0.log
========================================================================
Is it worth retrying *with* --enable-system-packages ?
--
Emmanuel Charpentier
----- Mail original -----
> De: "Dima Pasechnik" ***@***.***>
> À: "sagemath/sage" ***@***.***>
> Cc: "EmmanuelCharpentier" ***@***.***>, "Mention"
> ***@***.***>
> Envoyé: Jeudi 27 Février 2025 19:02:56
> Objet: Re: [sagemath/sage] bump executing to 2.2.0 (PR #39602)
>
>
>
> @jhpalmieri - please review
>
> —
> Reply to this email directly, view it on GitHub , or unsubscribe .
> You are receiving this because you were mentioned. Message ID:
> <sagemath/sage/pull/39602/c2688713040 @ github . com>
> dimpasedimpase left a comment (sagemath/sage#39602)
>
> @jhpalmieri - please review
>
> —
> Reply to this email directly, view it on GitHub , or unsubscribe .
> You are receiving this because you were mentioned. Message ID:
> <sagemath/sage/pull/39602/c2688713040 @ github . com>
|
|
your error messages say you either didn't do the update of Sages pillow and cffi, or did, but didn't run ./bootstrap && ./configure afterwards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's in particular needed to fix ipython error handling with Python 3.13
This will fix #39591
see #39591 (comment) by Tobias Diez
📝 Checklist
⌛ Dependencies