Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Extract strings #528

Merged
merged 21 commits into from
Aug 5, 2024
Merged

[WIP] Extract strings #528

merged 21 commits into from
Aug 5, 2024

Conversation

sailro
Copy link
Owner

@sailro sailro commented Jul 9, 2024

It's working when compiling from sources with VS.

Updated the installer (to convert resx to resource, then to embed into the assembly)

@solareon
Copy link
Collaborator

solareon commented Jul 9, 2024

I take it that this would be a precursor to allowing localization?

@sailro
Copy link
Owner Author

sailro commented Jul 9, 2024

I take it that this would be a precursor to allowing localization?

Yep exactly

@sailro
Copy link
Owner Author

sailro commented Jul 10, 2024

I think we are all good for now.

Will merge this when I'm back from vacations.

@solareon
Copy link
Collaborator

Alright. Sounds like a plan. If I get a chance I'll build and do some testing

@sailro sailro merged commit 0b974fe into master Aug 5, 2024
2 checks passed
@sailro sailro deleted the extract-strings branch August 5, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants