Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mailgun.sendHtmlEmail to support bcc #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update mailgun.sendHtmlEmail to support bcc #12

wants to merge 1 commit into from

Conversation

ericcarraway
Copy link

This PR updates mailgun.sendHtmlEmail to support bcc.

It makes the API of mailgun.sendHtmlEmail similar to the API of the newer sendgrid.sendHtmlEmail.

When using the sails new web app generator, bcc is an input in the sendTemplateEmail helper. However, if you switch from the (default) Sendgrid to Mailgun, that bcc input can't currently be passed to the Mailgun helper. Sails trims the bcc input and shows this warning:

WARNING: Automatically trimmed extraneous values!
In call to sendHtmlEmail(), 1 of the provided values (bcc) does not correspond with any recognized input.
Please try again without the extra value, or check your usage and adjust accordingly.

Mailgun's API documenting the bcc parameter:
https://documentation.mailgun.com/en/latest/api-sending.html#sending

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ericcarraway