Notify user when there is error with github API request

saiqulhaq · Jan 25, 2018 · 833a1ba · 833a1ba
1 parent 604396c
commit 833a1ba
Show file tree

Hide file tree

Showing 4 changed files with 52 additions and 21 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/components/Hackmap.vue b/src/components/Hackmap.vue
@@ -169,6 +169,13 @@ export default {
           const indexResult = this.projects.findIndex(project => project.id === id)
           this.projects.splice(indexResult, 1)
         })
+    },
+    notifyError (msg) {
+      if (msg.hasOwnProperty('message')) {
+        alert(msg.message)
+      } else {
+        alert('Oh no, something went wrong')
+      }
     }
   },
   components: {
@@ -197,7 +204,10 @@ export default {
         this.username = response.data.login
         this.userId = response.data.id
       },
-      issueNumber: this.issueNumber
+      issueNumber: this.issueNumber,
+      onError: errMsg => {
+        this.notifyError(errMsg)
+      }
     })
     // we need to calculate map dimensions in order to place the avatars
     // we handle three cases:

diff --git a/src/github-issues.js b/src/github-issues.js
@@ -50,7 +50,10 @@ export default class GitHubIssueService {
         this.issueNumber = issue.number
       })
       .then(() => this.pollIssueForComments())
-      .catch(err => this.reportError(err))
+      .catch(err => {
+        this.reportError(err)
+        config.onError(err)
+      })
   }
 
   postNewProject (project) {

diff --git a/test/github-api-client.test.js b/test/github-api-client.test.js
@@ -12,7 +12,7 @@ describe('baseURL', () => {
 
 let token = 'token'
 let config = {
-  organization: 'saiqulhaq',
+  organization: 'bkkhack',
   repository: 'hackmap',
 }