Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chat screen is getting stuck after Visitor ends engagement #1223

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Fix chat screen is getting stuck after Visitor ends engagement #1223

merged 2 commits into from
Jan 30, 2025

Conversation

gugalo
Copy link
Collaborator

@gugalo gugalo commented Jan 29, 2025

Jira issue:
https://glia.atlassian.net/browse/MOB-3975

What was solved?

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from Android SDKs → Things to consider for newly added logs in Confluence for more information.

Screenshots:

@gugalo gugalo requested a review from a team as a code owner January 29, 2025 09:22
@gugalo gugalo requested review from DavDo and andrews-moc January 29, 2025 10:00
@gugalo
Copy link
Collaborator Author

gugalo commented Jan 29, 2025

Pushed one more commit to this PR. Please review again

@gugalo gugalo merged commit d8a5940 into feature/entry-widget-and-secure-conversations-v2 Jan 30, 2025
7 checks passed
@gugalo gugalo deleted the MOB-3996 branch January 30, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavDo DavDo DavDo approved these changes

@andrews-moc andrews-moc andrews-moc approved these changes

@Andrii-Horishnii-Glia Andrii-Horishnii-Glia Awaiting requested review from Andrii-Horishnii-Glia

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gugalo @DavDo @andrews-moc