Add support for next safe action #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lkostrowski
reviewed
Sep 23, 2024
There was a problem hiding this comment.
is this commited on purpose?
There was a problem hiding this comment.
Yes - https://gql-tada.0no.co/get-started/workflows#uncommitted-output-files:
As you've seen on this page, there are two different output files we're concerned with when running inside an continuous integration environment.
- the output typings file (via the generate output command)
- the type cache file (via the turbo command)
Checking these files into your repository makes sure that your codebase is less reliant on running gql.tada, and that anyone who clones your code does not have to even know how to use gql.tada.
There was a problem hiding this comment.
makes sense, the same approach we should take on graphql-codegen in other places
lkostrowski
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for https://github.com/TheEdoRan/next-safe-action instead of custom logic in server actions