Add ONBOARDING_USER_JOINED_DATE_THRESHOLD to wokflows (#5290)

* Add ONBOARDING_USER_JOINED_DATE_THRESHOLD to wokflows * Update fallback date * Add changeset * Update .changeset/early-toes-occur.md Co-authored-by: Mikail <[email protected]> --------- Co-authored-by: Mikail <[email protected]>
saleor · Nov 29, 2024 · 4add531 · 4add531
1 parent c925f1a
commit 4add531
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 1 deletion.
diff --git a/.changeset/early-toes-occur.md b/.changeset/early-toes-occur.md
@@ -0,0 +1,5 @@
+---
+"saleor-dashboard": patch
+---
+
+Add environment variables to GitHub Workflow to control when to show onboarding for new users
diff --git a/.github/workflows/deploy-cloud.yaml b/.github/workflows/deploy-cloud.yaml
@@ -26,6 +26,7 @@ jobs:
       IS_CLOUD_INSTANCE: true
       POSTHOG_KEY: ${{ secrets.POSTHOG_KEY }}
       POSTHOG_HOST: ${{ secrets.POSTHOG_HOST }}
+      ONBOARDING_USER_JOINED_DATE_THRESHOLD: ${{ vars.CLOUD_ONBOARDING_USER_JOINED_DATE_THRESHOLD }}
     steps:
       - name: Check region
         if: ${{ !contains(fromJSON('["eu", "us"]'), env.REGION) }}

diff --git a/.github/workflows/deploy-dev.yaml b/.github/workflows/deploy-dev.yaml
@@ -26,6 +26,7 @@ jobs:
       SENTRY_DSN: ${{ secrets.SENTRY_DSN }}
       SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
       APPS_MARKETPLACE_API_URL: "https://apps.staging.saleor.io/api/v2/saleor-apps"
+      ONBOARDING_USER_JOINED_DATE_THRESHOLD: ${{ vars.DEV_ONBOARDING_USER_JOINED_DATE_THRESHOLD }}
       IS_CLOUD_INSTANCE: true
     steps:
       - uses: actions/checkout@v2

diff --git a/.github/workflows/deploy-master-staging.yaml b/.github/workflows/deploy-master-staging.yaml
@@ -26,6 +26,7 @@ jobs:
       IS_CLOUD_INSTANCE: true
       POSTHOG_KEY: ${{ secrets.POSTHOG_KEY }}
       POSTHOG_HOST: ${{ secrets.POSTHOG_HOST }}
+      ONBOARDING_USER_JOINED_DATE_THRESHOLD: ${{ vars.STAGING_ONBOARDING_USER_JOINED_DATE_THRESHOLD }}
     steps:
       - uses: actions/checkout@v2
       - name: Set custom version

diff --git a/.github/workflows/deploy-staging-and-prepare-release.yaml b/.github/workflows/deploy-staging-and-prepare-release.yaml
@@ -61,6 +61,7 @@ jobs:
       IS_CLOUD_INSTANCE: true
       POSTHOG_KEY: ${{ secrets.POSTHOG_KEY }}
       POSTHOG_HOST: ${{ secrets.POSTHOG_HOST }}
+      ONBOARDING_USER_JOINED_DATE_THRESHOLD: ${{ vars.STAGING_ONBOARDING_USER_JOINED_DATE_THRESHOLD }}
     steps:
       - uses: actions/checkout@v4
         with:

diff --git a/.github/workflows/pr-automation.yml b/.github/workflows/pr-automation.yml
@@ -121,6 +121,7 @@ jobs:
           APP_MOUNT_URI: /
           STATIC_URL: /
           IS_CLOUD_INSTANCE: true
+          ONBOARDING_USER_JOINED_DATE_THRESHOLD: ${{ vars.STAGING_ONBOARDING_USER_JOINED_DATE_THRESHOLD }}
         run: npm run build
 
       - name: Configure AWS credentials

diff --git a/src/welcomePage/WelcomePageOnboarding/hooks/useNewUserCheck.ts b/src/welcomePage/WelcomePageOnboarding/hooks/useNewUserCheck.ts
@@ -3,7 +3,7 @@ import moment from "moment";
 
 export const useNewUserCheck = () => {
   const { user } = useUser();
-  const thresholdDateString = process.env.ONBOARDING_USER_JOINED_DATE_THRESHOLD || "2024-01-01";
+  const thresholdDateString = process.env.ONBOARDING_USER_JOINED_DATE_THRESHOLD || "2024-11-29";
 
   if (!user) {
     return {