Add explicit waits for draft order shipping carrier button interaction (

#5324) * Add explicit waits for draft order shipping carrier button interaction * Add fixes from review
saleor · Dec 27, 2024 · ab543c5 · ab543c5
1 parent 7c0c89d
commit ab543c5
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/.changeset/thin-drinks-kneel.md b/.changeset/thin-drinks-kneel.md
@@ -0,0 +1,5 @@
+---
+"saleor-dashboard": patch
+---
+
+Add explicit waits for draft order shipping carrier button interaction
diff --git a/playwright/pages/draftOrdersPage.ts b/playwright/pages/draftOrdersPage.ts
@@ -60,7 +60,9 @@ export class DraftOrdersPage extends BasePage {
   }
 
   async clickAddShippingCarrierButton() {
+    await this.addShippingCarrierLink.scrollIntoViewIfNeeded();
     await this.addShippingCarrierLink.click();
+
     await this.waitForDOMToFullyLoad();
   }
 

diff --git a/playwright/tests/orders.spec.ts b/playwright/tests/orders.spec.ts
@@ -251,9 +251,15 @@ test("TC: SALEOR_84 Create draft order @e2e @draft", async () => {
   await draftOrdersPage.expectSuccessBanner();
   await draftOrdersPage.addressDialog.clickConfirmButton();
   await draftOrdersPage.expectSuccessBanner();
+
+  await draftOrdersPage.addShippingCarrierLink.waitFor({ state: "visible" });
+  // Ensure the button is in viewport before clicking
+  await draftOrdersPage.addShippingCarrierLink.scrollIntoViewIfNeeded();
+
+  await expect(draftOrdersPage.addShippingCarrierLink).toBeVisible();
   await draftOrdersPage.clickAddShippingCarrierButton();
+
   await draftOrdersPage.shippingAddressDialog.pickAndConfirmFirstShippingMethod();
-  //await draftOrdersPage.expectSuccessBanner();
   await draftOrdersPage.clickFinalizeButton();
   await draftOrdersPage.expectSuccessBanner({ message: "finalized" });
 });