Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technical help section in homepage #5171

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Conversation

Cloud11PL
Copy link
Member

@Cloud11PL Cloud11PL commented Sep 19, 2024

What type of PR is this?

  • 💅 Refactor
  • 🌟 Feature
  • 🔥 Bug Fix
  • 🔩 Maintenance
  • 🛠 Workflow CI/CD changes

Related Issues or Documents

  • closes #

Usage Instructions, Screenshots, Recordings

CleanShot 2024-09-20 at 10 42 07

Have you written tests?

  • Yes!
  • No... here is why: Writing tests are mandatory, please replace this text with why test are not included in this PR

[Optional] Description

Copy link

changeset-bot bot commented Sep 19, 2024

🦋 Changeset detected

Latest commit: fbf99d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pr-5171 September 19, 2024 14:27 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5171 September 19, 2024 14:35 Destroyed
@Cloud11PL Cloud11PL force-pushed the MERX-908-help-section-home-page branch from 2bb0c7e to eb5a1e0 Compare September 20, 2024 08:40
@github-actions github-actions bot temporarily deployed to pr-5171 September 20, 2024 08:43 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5171 September 20, 2024 08:48 Destroyed
@Cloud11PL Cloud11PL marked this pull request as ready for review September 20, 2024 09:14
@Cloud11PL Cloud11PL requested a review from a team as a code owner September 20, 2024 09:14
@github-actions github-actions bot temporarily deployed to pr-5171 September 20, 2024 09:16 Destroyed
</DashboardCard.Content>

<DashboardCard.BottomActions paddingTop={2}>
<Button as="a" target="_blank" href={externalHref} variant="secondary" alignSelf="start">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use TECHNICAL_HELP_CTA_URL directly here? do you need prop?

poulch
poulch previously approved these changes Sep 20, 2024
@github-actions github-actions bot temporarily deployed to pr-5171 September 20, 2024 11:28 Destroyed
@Cloud11PL Cloud11PL merged commit eb981d0 into main Sep 20, 2024
15 checks passed
@Cloud11PL Cloud11PL deleted the MERX-908-help-section-home-page branch September 20, 2024 12:25
poulch pushed a commit that referenced this pull request Sep 23, 2024
* technical help card in home page

* change link

* bump macaw, import url directly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants