Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swatch attribute preview when selecting image #5226

Merged
merged 8 commits into from
Oct 23, 2024

Conversation

andrzejewsky
Copy link
Member

What type of PR is this?

  • 💅 Refactor
  • 🌟 Feature
  • 🔥 Bug Fix
  • 🔩 Maintenance
  • 🛠 Workflow CI/CD changes

Related Issues or Documents

  • closes #

Usage Instructions, Screenshots, Recordings

Have you written tests?

  • Yes!
  • No... here is why: Writing tests are mandatory, please replace this text with why test are not included in this PR

[Optional] Description

Copy link

changeset-bot bot commented Oct 22, 2024

🦋 Changeset detected

Latest commit: 5806548

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pr-5226 October 22, 2024 14:59 Destroyed
@andrzejewsky andrzejewsky requested a review from a team as a code owner October 23, 2024 08:24
@github-actions github-actions bot temporarily deployed to pr-5226 October 23, 2024 08:27 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5226 October 23, 2024 08:32 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5226 October 23, 2024 08:46 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5226 October 23, 2024 09:11 Destroyed
poulch
poulch previously approved these changes Oct 23, 2024
@github-actions github-actions bot temporarily deployed to pr-5226 October 23, 2024 09:41 Destroyed
@andrzejewsky andrzejewsky merged commit e269b46 into main Oct 23, 2024
14 of 15 checks passed
@andrzejewsky andrzejewsky deleted the merx-1009-swatch-attribute-images branch October 23, 2024 12:23
poulch pushed a commit that referenced this pull request Oct 23, 2024
* Handle swatch preview

* Handle swatch preview

* Handle swatch preview

* Translations

* Translations

* Translations

* Fix list

* Fix list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants