Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add password to artifact #5334

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add password to artifact #5334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7bd99c3
Add password to artifact
karola312 Jan 4, 2025
45a79f8
Add changeset
karola312 Jan 10, 2025
d01715c
Merge branch 'main' into qag-258-Secure-tokens-in-artifacts
poulch Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wicked-llamas-do.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"saleor-dashboard": patch
---

Tests reports from artifacts will be protected by password
15 changes: 12 additions & 3 deletions .github/actions/merge-pw-reports/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
name: Merge playwright reports
description: Merge reports from all shards

inputs:
PASSWORD_FOR_DECODING_ARTIFACT:
description: "Password for decoding artifact"
required: true

runs:
using: "composite"
steps:
Expand All @@ -21,11 +26,15 @@ runs:

- name: Merge into HTML Report
shell: bash
run: npx playwright merge-reports --reporter html ./all-blob-reports
env:
PASSWORD_FOR_DECODING_ARTIFACT: ${{ inputs.PASSWORD_FOR_DECODING_ARTIFACT }}
run: |
npx playwright merge-reports --reporter html ./all-blob-reports
zip -P $PASSWORD_FOR_DECODING_ARTIFACT secure-report.zip -r ./playwright-report

- name: Upload HTML report
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v3
with:
name: html-report--attempt-${{ github.run_attempt }}
path: playwright-report
path: secure-report.zip
retention-days: 14
4 changes: 3 additions & 1 deletion .github/workflows/pr-automation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,4 +201,6 @@ jobs:
- uses: actions/checkout@v4

- name: Merge playwright reports
uses: ./.github/actions/merge-pw-reports
uses: ./.github/actions/merge-pw-reports
with:
PASSWORD_FOR_DECODING_ARTIFACT: ${{ secrets.E2E_USER_PASSWORD }}
2 changes: 2 additions & 0 deletions .github/workflows/run-test-manual.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,8 @@ jobs:

- name: Merge playwright reports
uses: ./.github/actions/merge-pw-reports
with:
PASSWORD_FOR_DECODING_ARTIFACT: ${{ secrets.E2E_USER_PASSWORD }}

- name: complete testmo report
uses: ./.github/actions/testmo/testmo-finish
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/run-tests-on-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,8 @@ jobs:
- name: Merge playwright reports
if: needs.add-check-and-prepare-instance.outputs.FRAMEWORK == '"playwright"'
uses: ./.github/actions/merge-pw-reports
with:
PASSWORD_FOR_DECODING_ARTIFACT: ${{ secrets.E2E_USER_PASSWORD }}

- name: Merge cypress reports
if: needs.add-check-and-prepare-instance.outputs.FRAMEWORK == '"cypress"'
Expand Down
Loading