Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REL #250 Remove request of bootstrap.min.css #283

Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from

Conversation

lukio
Copy link
Contributor

@lukio lukio commented Jun 7, 2023

The file boostrap.min.css it's missing under the theme css folder.

The file under the css folder of suite8 theme there are the boostrap files uncompressed, and they are imported with the style.scss file of Dawn or Noon styles, so the line of layout_utils.php it's need it.

Issue: #250

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

The file boostrap.min.css it's missing under the theme css folder.

The file under the css folder of suite8 theme there are the boostrap
files uncompressed, and they are imported with the style.scss file of
Dawn or Noon styles, so the line of layout_utils.php it's need it.
@lukio lukio added Status: Requires Code Review Status: Fix Proposed A issue that has a PR related to it that provides a possible resolution labels Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Fix Proposed A issue that has a PR related to it that provides a possible resolution Status: Requires Code Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant