Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #373 Google API Token for calendar sync in User Profile not working #374

Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from

Conversation

abuzarfaris
Copy link
Contributor

@abuzarfaris abuzarfaris commented Oct 30, 2023

Open the Google auth window in a new tab

Description

Motivation and Context

How To Test This

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

…le not working

Open the Google auth window in a new tab
@clemente-raposo
Copy link
Contributor

Hi @abuzarfaris

Thank you for your PR.

salesagility/SuiteCRM-Core repo uses salesagility/SuiteCRM as a subrepo, which allows SuiteCRM 8 to re-use SuiteCRM 7 code base and also get new feaures and fixes from SuiteCRM 7.

Since this fix is on legacy EditViewFooter.tpl it is also applicable to 7.14. Would you have a chance to re-create in the https://github.com/salesagility/SuiteCRM repo, please?

It would be the best approach as we would fix the issue on SuiteCRM 7 and on SuiteCRM 8 with just on PR.

@clemente-raposo clemente-raposo added the Status:Requires Updates Issues & PRs which requires input or update from the author label Oct 30, 2023
@abuzarfaris
Copy link
Contributor Author

abuzarfaris commented Oct 30, 2023

Hi @abuzarfaris

Thank you for your PR.

salesagility/SuiteCRM-Core repo uses salesagility/SuiteCRM as a subrepo, which allows SuiteCRM 8 to re-use SuiteCRM 7 code base and also get new feaures and fixes from SuiteCRM 7.

Since this fix is on legacy EditViewFooter.tpl it is also applicable to 7.14. Would you have a chance to re-create in the https://github.com/salesagility/SuiteCRM repo, please?

It would be the best approach as we would fix the issue on SuiteCRM 7 and on SuiteCRM 8 with just on PR.

@clemente-raposo This issue only occurs in suitecrm 8. in suitecrm 7 it works fine with existing

window.open('{$GOOGLE_API_TOKEN_NEW_URL}', '_self')

@chris001
Copy link
Contributor

Would this fix make the Authorize work on both 7.x and 8.x? Then a PR should be made for 7.x and then it will be automatically added to 8.x. So that the two code bases would remain as identical as possible.

@abuzarfaris
Copy link
Contributor Author

Would this fix make the Authorize work on both 7.x and 8.x? Then a PR should be made for 7.x and then it will be automatically added to 8.x. So that the two code bases would remain as identical as possible.

@chris001 Yes it will work on suitecrm 7 as well

@abuzarfaris
Copy link
Contributor Author

@chris001 @clemente-raposo
Created a new PR on SuiteCRM 7 repo
salesagility/SuiteCRM#10271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Requires Updates Issues & PRs which requires input or update from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants