Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #168 Contact Email Address not showing in Subpanels #417

Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from

Conversation

chris001
Copy link
Contributor

The Emails column of the Contacts subpanel in the Accounts module is empty! It should contain the primary email address of each related Contact. Serious issue for users!

Description

Quick and dirty fix to this issue. Thanks to forum user azzy9.
Note, There may be a more standard way to fix this, for example, check for missing relationship Contact to primary Email address, and add it.

Motivation and Context

Users cannot see email address, in the Contacts subpnel, of Contacts related to an Account.

How To Test This

Before this fix, go to an Account, open the Contacts subpanel, you'll see the Email column is empty for all Contacts related to this Account.
After this fix, you'll see the expected Email addresses in the Email column of the Contacts subpanel of an Account.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

The entire Emails column of the Contacts subpanel in the Accounts module was empty.  It should have email addresses of the related Contacts.
@serhiisamko091184 serhiisamko091184 added Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Area: Contacts Issues & PRs related to all things regarding contacts Status: Requires Code Review labels Jan 4, 2024
@serhiisamko091184
Copy link
Contributor

Hello @chris001,

thanks for your contribution!

Regards,
Serhii

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Contacts Issues & PRs related to all things regarding contacts Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Passed Code Review Status: Passed Testing Status: Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants