Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #274 - Fix Views HTML Entities Which Encode UTF Characters Incorrectly #403 #501

Open
wants to merge 2 commits into
base: hotfix
Choose a base branch
from
Open

Fix #274 - Fix Views HTML Entities Which Encode UTF Characters Incorrectly #403 #501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a431f0
Fix #274 - Views Incorrectly Encode UTF Characters as HTML Entities
GoryMoon Nov 26, 2023
ff1ed1d
Add html decoding on mappers
yunusyerli1 Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/backend/Data/LegacyHandler/PresetDataHandlers/HistoryTimelineDataHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,10 @@ public function fetch(
$listData[$key]['assigned_user_name']['user_name'] = $user->user_name ?? '';
$listData[$key]['assigned_user_name']['user_id'] = $record['assigned_user_id'];
$listData[$key]['module_name'] = $panelToModuleName[$listData[$key]['panel_name']];
$listData[$key]['description'] = html_entity_decode($listData[$key]['description'] ?? '', ENT_QUOTES);
$listData[$key]['name'] = html_entity_decode($listData[$key]['name'] ?? '', ENT_QUOTES);
$listData[$key]['status'] = html_entity_decode($listData[$key]['status'] ?? '', ENT_QUOTES);

}

$timelineEntryData = new ListData();
Expand Down
2 changes: 1 addition & 1 deletion public/legacy/include/portability/ApiBeanMapper/TypeMappers/ParentMapper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ public function toApi(SugarBean $bean, array &$container, string $name, string $
}

$relate['id'] = $parentId;
$relate[$rName] = $bean->$name ?? '';
$relate[$rName] = html_entity_decode($bean->$name ?? '', ENT_QUOTES);

$container[$newName] = $relate;
}
Expand Down
1 change: 1 addition & 0 deletions public/legacy/include/utils/db_utils.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ function from_db_convert($string, $type)
'>' => '>',
"'" => ''',
);
$GLOBALS['toHTML'] = $toHTML;
$GLOBALS['toHTML_keys'] = array_keys($toHTML);
$GLOBALS['toHTML_values'] = array_values($toHTML);
$GLOBALS['toHTML_keys_set'] = implode("", $GLOBALS['toHTML_keys']);
Expand Down