Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10425 - Value of "currency_id" in custom table changes from NULL to an empty string when saving #10527

Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from

Conversation

serhiisamko091184
Copy link
Contributor

Description

See the issue:
#10425

Motivation and Context

How To Test This

See the issue:
#10425

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

johnM2401
johnM2401 previously approved these changes Sep 16, 2024
@gunnicom
Copy link
Contributor

gunnicom commented Sep 19, 2024

I would fix that globally by changing one line in D manager.php. I do not have my fix at hand because I am on vacation right now.
I think it is just adding a && strlen($data[$field])>0) to this line

if (isset($data[$field])) {

Works for me since years and solves additional problems if for example you really need a unique column and so define it in the database table.
Already commented that on #9524
But of course we can make code more complicated by just doing more ifs for each data type.

…es from NULL to an empty string when saving
@serhiisamko091184 serhiisamko091184 added the Status: Ready to Merge PRs that have passed QA & can be merged into next release batch label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Passed Code Review Mark issue has passed code review reviewed Status: Passed Testing Status: Ready to Merge PRs that have passed QA & can be merged into next release batch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants