Skip to content
This repository has been archived by the owner on Jan 20, 2024. It is now read-only.

option to read from config. Fix php 7 issues #165

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rodruiz
Copy link

@rodruiz rodruiz commented Feb 4, 2021

Fixes:

To read the config file from a custom path:

$myclient = new ET_Client(true, false, null, true, '/path/to/config.php');

To ignore config file:

$params = array(...);
$myclient = new ET_Client(true, false, $params, false);

I can submit another PR to optimize and remove duplicate code from ET_Client constructor. Merging $params with $config should do the trick.

@PWalkow
Copy link

PWalkow commented Apr 12, 2021

Why this fix wasn't merged yet?

@dsepulveda-pr
Copy link

dsepulveda-pr commented Oct 27, 2021

is there another plan for this, why is still not merged?

@rodruiz
Copy link
Author

rodruiz commented Oct 27, 2021

@PWalkow and @dsepulveda-pr you can use my branch doing the following:

1- Add the following to your composer.json file

    "repositories": [
        {
            "type": "git",
            "url": "https://github.com/rodruiz/FuelSDK-PHP.git"
        }
    ]

2- Replace:

{
    "require": {
        "salesforce-mc/fuel-sdk-php": "1.4.0"
    }
}

with:

{
    "require": {
        "salesforce-mc/fuel-sdk-php": "dev-master"
    }
}

@JeremyDunn
Copy link

@manivinesh Looks like you have approved previous PRs. Would you mind reviewing this one? This sdk is unusable in PHP 7.4 at the moment.

@boxyashish
Copy link

can someone please review and merge this PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants