fix(engine-dom): append global stylesheets to document.head #2923
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
In #2827 we started using
document.adoptedStyleSheets
instead of injecting<style>
s into thedocument.head
(in supported browsers). Unfortunately this breaks existing code that expects that it can crawl the CSS for all elements on the page by iterating throughdocument.styleSheets
. (As it turns out,document.adoptedStyleSheets
does not affectdocument.styleSheets
– they are separate collections.)I opened #2922 to track removing this once it's safe to go back to using
document.adoptedStyleSheets
.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
Gus WI
W-11393601