fix(ssr): handle export { Cmp as default } @W-17655297
#5176
+121
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| export function unimplementedTmpl(tagName: string, Cmp?: LightningElementConstructor): string { | ||
| let html = `<${tagName}>`; | ||
| if (Cmp?.renderMode !== 'light') { | ||
| html += '<template shadowrootmode="open"></template>'; |
There was a problem hiding this comment.
Should we be rendering the slotted content here?
jhefferman-sfdc
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
The most correct thing to do would be to treat
export { Cmp as default }identically toexport default Cmp. But engine-server's "what is an LWC component" logic is faulty, soexport { Cmp as default }is kinda a component, but also kinda not. It's weird.Partially addresses #4020 for
ssr-compiler.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item