Skip to content

Commit

Permalink
🖼 Updates (#21)
Browse files Browse the repository at this point in the history
* made the header responsive, updated the readme

* update: readme
  • Loading branch information
salil-naik authored Apr 2, 2021
1 parent 5820d7c commit 9e25df6
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 16 deletions.
3 changes: 2 additions & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ To fill the checklists, put x inside the brackets. [x]
- [] I have added just one folder that includes my Art files (jsx and css)
- [] I have not edited App.js file
- [] I have commented my code, particularly in hard-to-understand areas
- [] My changes generate no new warnings
- [] My changes generate no new warnings
- [] This is my original code and I have NOT copied the code from anywhere else.
13 changes: 7 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,24 +5,25 @@


## Run the project
Run the `yarn start` command in the terminal
Run the `yarn install` command in the terminal to downlaod the dependencies.
Run the `yarn start` command to run the project in the development mode.

This command will run the app in the development mode.
Open http://localhost:3000 to view it in the browser.

The page will reload if you make edits.

<br />

## Some rules and suggestions for making the CSS Art.

1. Create your own folder inside the `/art` folder.
2. Folder name should be as follows. YourName + ArtName <br />For example, SalilNaikTeddy,
1. Create your folder inside the `/art` folder.
2. The folder name should be as follows. YourName + ArtName <br />For example, SalilNaikTeddy,
3. Give [gradient](https://uigradients.com/) or solid background colours to the `.container` class. Kindly do not keep the background white in colour.
4. To test your component, import your component to app.js. DO NOT FORGET to remove the import from App.js before you push. Since multiple contributors are going to contribute at the same time, almost every contributor will get merge conflicts. So, edit app.js file only for test purpose, DO NOT push app.js changes to GitHub.
5. Check out `index.css` for common CSS. DO NOT EDIT THIS FILE.
6. If you are coding an object inside the container, for example, a logo, a geometrical shape or an object, kindly make sure the total dimensions (width and height) do not exceed 150px. You may take up to 180px only when required.
7. When you create a pull request, please specify `updates` branch as all the contributor's changes are going to be merged in the `updates` branch and then to the `main` branch.
7. Do not copy the code from elsewhere. If I find any code has been plagiarised from some other platform, I'll have to revert the PR and block you from making any further contributions.
8. Please create an issue and start working only after it is assigned to you. During live sessions, you may directly start working without having the issue assigned to you as it might not be feasible for me to assign issues to individuals. But it is important to create an issue so that others don't work on the same art as you are working on.
9. When you create a pull request, please specify the `updates` branch as all the contributor's changes are going to be merged in the `updates` branch and then to the `main` branch.

### Folder Structure

Expand Down
4 changes: 2 additions & 2 deletions src/components/Header/Header.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@ export function Header() {
});
return (
<div className={style.header}>
<div className={style.container}>
<div className={`${style.container} grid-container`}>
<div className={style.title}>
<div className={style.square}></div>
<div className={style.circle}></div>
<div className={style.shape}></div>
<div>CSS Art Gallery</div>
<p className={style.titleText}>CSS Art Gallery</p>
</div>
<a
href="https://github.com/salil-naik/css-art-gallery"
Expand Down
15 changes: 8 additions & 7 deletions src/components/Header/header.module.css
Original file line number Diff line number Diff line change
@@ -1,19 +1,12 @@
.header {
height: 60px;
color: white;
/* background-color: #2E2F33; */
background: #111;
/* border-bottom: 2px solid rgb(255, 114, 98); */
box-shadow: 0px 4px 10px rgba(0, 0, 0, 0.18);
/* position: fixed;
top: 0;
left: 0; */
width: 100%;
/* z-index: 10; */
}

.container {
padding: 0 30px;
display: flex;
justify-content: space-between;
}
Expand Down Expand Up @@ -75,3 +68,11 @@
line-height: 41px;
font-size: 14px;
}


@media screen and (max-width: 39.9375em) {
.titleText{display:none;}
.container{
padding:0 15px;
}
}

0 comments on commit 9e25df6

Please sign in to comment.