Pool ActiveQuerys in the query stack
#629
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #629 will not alter performanceComparing Summary
|
Veykril
changed the title
ActiveQuerys in the query stack
* master: Add unit tests for AtomicInputAccumulatedValues and OptionalAtomicRevision Replace `crossbeam` dependency with `crossbeam-queue` Remove unnecessary `Mutex` from singleton initialization Drop unnecssary usages of `AtomicCell`
* master: Drop unnecessary `AtomicRevision` Mark `MemoTable` methods that evict entries unsafe LRU eviction at revision bump
Veykril
force-pushed
the
veykril/push-vznumyusmzww
branch
from
f3f6cc4 to
5d9e78c
Compare
* master: ci: use `release-plz` for release internal: switch to `boxcar` from `append-only-vec` Deduplicate `Storage` and `StorageHandle` fields More test cases for `tracked_fn_return_ref` Emit better diagnostic for invalid tracked function return types `black_box` benchmark inputs and outputs Introduce `RefUnwindSafe` `StorageHandle` add guide of releasing add release workflow
* master: Reduce method delegation duplication Automatically clear the cancellation flag when cancellation completes Allow trigger LRU eviction without increasing the current revision Simplify `Ingredient::reset_for_new_revision` setup Require mut Zalsa access for setting the lru limit Split off revision bumping from `zalsa_mut` access
* master: Remove some `ZalsaDatabase::zalsa` calls Remove outdated FIXME Replace `IngredientCache` lock with atomic primitive
* master: update MSRV to 1.80 and test it in CI
Veykril
force-pushed
the
veykril/push-vznumyusmzww
branch
from
5d9e78c to
c2e00ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActiveQueryis 192 bytes and has a couple of collections within it (2 of which are not extract) that we can potentially re-use the allocations for. So pooling those instead of creating, pushing and popping the query from the stack might be beneficial to perf.Seems like we have small perf improvements.
Based on top of #603