Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce unsafe_op_in_unsafe_fn #713

Merged
merged 1 commit into from
Feb 23, 2025

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Feb 22, 2025

We'll need to do this for the 2024 edition upgrade. The motivation for this change thouhgh is so I can quickly check whether the merge queue works now (and so I'll self approve this)

@Veykril Veykril enabled auto-merge February 22, 2025 08:41
Copy link

netlify bot commented Feb 22, 2025

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit 68e26c0
🔍 Latest deploy log https://app.netlify.com/sites/salsa-rs/deploys/67b98da715ecb0000839959b

Copy link

codspeed-hq bot commented Feb 22, 2025

CodSpeed Performance Report

Merging #713 will not alter performance

Comparing Veykril:veykril/push-rtrowyplmxzw (68e26c0) with master (70a0172)

Summary

✅ 9 untouched benchmarks

@MichaReiser
Copy link
Contributor

MichaReiser commented Feb 22, 2025

We'll need to do this for the 2024 edition upgrade.

Is my understanding correct that an 2024 edition upgrade would require bumping the MSRV to 1.85? Bumping the MSRV is technically a breaking change for Ruff because users can build Ruff from source. That's why we try to only bump the MSRV when necessary.

@Veykril
Copy link
Member Author

Veykril commented Feb 22, 2025

Yes it would require 1.85 (or later). I didn't mean to imply we should do that ASAP (though I think Niko would love 1.86 for trait upcasting).

I do think we want to release 1.0 proper on 2024 edition rules though. The MSRV story is definitely a meeting discussion topic.

@Veykril
Copy link
Member Author

Veykril commented Feb 22, 2025

Okay I think the merge queue works now (its blocking on the CI check introduced in #712)

@Veykril Veykril added this pull request to the merge queue Feb 23, 2025
Merged via the queue into salsa-rs:master with commit daeb285 Feb 23, 2025
10 checks passed
@Veykril Veykril deleted the veykril/push-rtrowyplmxzw branch February 23, 2025 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants