Skip to content

Commit

Permalink
test: fix rubocop violations
Browse files Browse the repository at this point in the history
Use method:

1. `rubocop -a --safe`
2. `rubocop -A --safe`
3. Use `rubocop:disable`

```
Offenses:

test/integration/default/controls/config_spec.rb:1:1: C: Style/FrozenStringLiteralComment: Missing frozen string literal
comment.
control 'Php configuration' do
^
test/integration/default/controls/config_spec.rb:4:3: C: Metrics/AbcSize: Assignment Branch Condition size for
test_debian is too high. [<0, 26, 0> 26/17]
(http://c2.com/cgi/wiki?AbcMetric, https://en.wikipedia.org/wiki/ABC_Software_Metric)
  def test_debian ...
  ^^^^^^^^^^^^^^^
test/integration/default/controls/config_spec.rb:4:3: C: Metrics/MethodLength: Method has too many lines. [14/10]
(https://rubystyle.guide#short-methods)
  def test_debian ...
  ^^^^^^^^^^^^^^^
test/integration/default/controls/config_spec.rb:24:3: C: Style/EmptyMethod: Put empty method definitions on a single
line. (https://rubystyle.guide#no-single-line-methods)
  def test_redhat ...
  ^^^^^^^^^^^^^^^
test/integration/default/controls/config_spec.rb:27:3: C: Style/EmptyMethod: Put empty method definitions on a single
line. (https://rubystyle.guide#no-single-line-methods)
  def test_suse ...
  ^^^^^^^^^^^^^
test/integration/default/controls/package_spec.rb:1:1: C: Style/FrozenStringLiteralComment: Missing frozen string
literal comment.
control 'Php package' do
^
test/integration/default/controls/package_spec.rb:4:3: C: Metrics/AbcSize: Assignment Branch Condition size for
test_debian is too high. [<1, 26, 1> 26.04/17] (http://c2.com/cgi/wiki?AbcMetric,
https://en.wikipedia.org/wiki/ABC_Software_Metric)
  def test_debian ...
  ^^^^^^^^^^^^^^^
test/integration/default/controls/package_spec.rb:4:3: C: Metrics/MethodLength: Method has too many lines. [20/10]
(https://rubystyle.guide#short-methods)
  def test_debian ...
  ^^^^^^^^^^^^^^^
test/integration/default/controls/package_spec.rb:21:1: C: Layout/EmptyLinesAroundBlockBody: Extra empty line detected
at block body beginning. (https://rubystyle.guide#empty-lines-around-bodies)
test/integration/default/controls/service_spec.rb:1:1: C: Style/FrozenStringLiteralComment: Missing frozen string
literal comment.
control 'Php service' do
^
test/integration/default/controls/service_spec.rb:16:3: C: Style/EmptyMethod: Put empty method definitions on a single
line. (https://rubystyle.guide#no-single-line-methods)
  def test_redhat ...
  ^^^^^^^^^^^^^^^
test/integration/default/controls/service_spec.rb:19:3: C: Style/EmptyMethod: Put empty method definitions on a single
line. (https://rubystyle.guide#no-single-line-methods)
  def test_suse ...
  ^^^^^^^^^^^^^

7 files inspected, 12 offenses detected, 8 offenses auto-correctable
```
  • Loading branch information
myii committed Dec 22, 2020
1 parent f88fdf7 commit 1a4d208
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 9 deletions.
10 changes: 6 additions & 4 deletions test/integration/default/controls/config_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
# frozen_string_literal: true

control 'Php configuration' do
title 'should match desired lines'

# rubocop:disable Metrics/MethodLength, Metrics/AbcSize
def test_debian
describe file('/etc/php/5.6/fpm/pool.d/radius-admin.conf') do
its('content') { should include '[radius-admin]' }
Expand All @@ -20,12 +23,11 @@ def test_debian
its('content') { should include 'date.timezone = Europe/Paris' }
end
end
# rubocop:enable Metrics/MethodLength, Metrics/AbcSize

def test_redhat
end
def test_redhat; end

def test_suse
end
def test_suse; end

case os[:family]
when 'debian'
Expand Down
5 changes: 4 additions & 1 deletion test/integration/default/controls/package_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
# frozen_string_literal: true

control 'Php package' do
title 'should be installed'

# rubocop:disable Metrics/MethodLength, Metrics/AbcSize
def test_debian
describe package('php-imagick') do
it { should be_installed }
Expand All @@ -18,7 +21,6 @@ def test_debian
bz2 cli curl fpm gd imap intl mbstring
mysql readline xml zip
].each do |pkg|

describe package("php5.6-#{pkg}") do
it { should be_installed }
end
Expand All @@ -28,6 +30,7 @@ def test_debian
end
end
end
# rubocop:enable Metrics/MethodLength, Metrics/AbcSize

def test_redhat
describe package('php') do
Expand Down
8 changes: 4 additions & 4 deletions test/integration/default/controls/service_spec.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

control 'Php service' do
title 'should be running and enabled'

Expand All @@ -13,11 +15,9 @@ def test_debian
end
end

def test_redhat
end
def test_redhat; end

def test_suse
end
def test_suse; end

case os[:family]
when 'debian'
Expand Down

0 comments on commit 1a4d208

Please sign in to comment.