Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apache2/ini: fix config merge #193

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ze42
Copy link

@ze42 ze42 commented Aug 19, 2019

fix merge like other ini files

fix merge like other ini files
@myii
Copy link
Member

myii commented Aug 19, 2019

Thanks for this, @ze42. A couple of things to consider:

This repo now uses semantic-release, which means that commit messages are significant. The explanation is available in the log:

✖   subject may not be empty [subject-empty]
✖   type may not be empty [type-empty]

Only the commit title would need to be modified, the body can stay as-is. So a suggestion:

-apache2/ini: fix config merge
+fix(apache2/ini): fix config merge

The second thing is that this will probably have to be merged after #183. We've caused the author of that PR far too much hassle every time we merge a PR, so this PR will have a simple adjustment afterwards in comparison. If you're a user of this formula, it would be great if you could test #183 at your end so that we can get on with merging it.

@myii
Copy link
Member

myii commented Aug 26, 2019

@ze42 Apologies, with the merge of #183, this will need amending before it can be reviewed and merged.

@n-rodriguez
Copy link
Member

Hi there! Any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants