-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump minimum Go version to 1.19 #313
Conversation
Not urgent, we could wait till Go 1.21 is released(may be in 2-3 weeks time). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm perpetually perplexed by the precise meaning of the go version present in the go.mod file. I'm pretty positive that they're even planning to change it. Usually I prefer to see the build versions change but not the mod file. But I am not going to pester you about it.
Go 1.21 is out now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "build:" is not the appropriate componeb for both the commit and the PR since this PR changes both the build itself and the github workflow actions.
I think these two changes should be separated in two commits and maybe two dependent PRs ...
Pull request has been modified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
I agree with @obnoxxx that the build
commit probably should be two commits but it doesn't bother me enough to block the PR.
Unfortunately, we're now going to continue to play catch-up because Go 1.21 has been released, making 1.19 now out of support so we should follow up with updates to 1.20... at least for the CI and containers (hopefully not go.mod again)
Signed-off-by: Anoop C S <[email protected]>
Signed-off-by: Anoop C S <[email protected]>
Signed-off-by: Anoop C S <[email protected]>
Signed-off-by: Anoop C S <[email protected]>
Signed-off-by: Anoop C S <[email protected]>
Pull request has been modified.
Updated once more. |
Split into smaller commits and updated the PR title.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
🎉 All dependencies have been resolved ! |
/retest centos-ci/sink-clustered/mini-k8s-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
depends on samba-in-kubernetes/samba-centosci#28