Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resources: fix case of nil PodAntiAffinity #331

Merged

Conversation

synarete
Copy link
Collaborator

Protect from case where user provided 'affinity' entry in podSettings of smbcommonconfig but without 'podAntiAffinity' sub-entry. This in turn would cause samba-operator a nil pointer dereference.

Fixes: #330

Protect from case where user provided 'affinity' entry in podSettings of
smbcommonconfig but without 'podAntiAffinity' sub-entry. This in turn
would cause samba-operator a nil pointer dereference.

Fixes: samba-in-kubernetes#330

Signed-off-by: Shachar Sharon <[email protected]>
Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix.

Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit ba72432 into samba-in-kubernetes:master Mar 4, 2024
13 checks passed
@mergify mergify bot added the priority-review This PR deserves a look label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-review This PR deserves a look
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Samba-operator crashes when setting affinity in clustered samba server
3 participants