Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few improvements to test-info.yml #111

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

anoopcs9
Copy link
Collaborator

@anoopcs9 anoopcs9 commented Jul 5, 2024

  • Remove an unnecessary variable definition.
  • Add variant in addition to backend.

depends on samba-in-kubernetes/sit-test-cases#89

@anoopcs9 anoopcs9 force-pushed the define-variant-test-info branch 3 times, most recently from d415638 to 0ef7e54 Compare July 9, 2024 06:26
@anoopcs9
Copy link
Collaborator Author

anoopcs9 commented Jul 9, 2024

/retest centos-ci/cephfs.vfs

Copy link

dpulls bot commented Jul 9, 2024

🎉 All dependencies have been resolved !

@anoopcs9 anoopcs9 requested a review from spuiuk July 9, 2024 19:33
'test_backend' was defined as config.be.name which is already available
for consumption inside test-info.yml.j2. Therefore remove the extra
'test_backend' definition while creating test-info.yml.

Signed-off-by: Anoop C S <[email protected]>
This is in preparation to support dedicated flapping list for backend
variants.

Signed-off-by: Anoop C S <[email protected]>
Copy link
Collaborator

@spuiuk spuiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@anoopcs9 anoopcs9 merged commit 4e3d505 into samba-in-kubernetes:main Jul 10, 2024
9 checks passed
@anoopcs9 anoopcs9 deleted the define-variant-test-info branch July 10, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants