metrics: allow passing explicit port-num

Allow running exporter with explicit port-number. If input port-number is non positive, use default port-number. Signed-off-by: Shachar Sharon <[email protected]>
samba-in-kubernetes · Jul 7, 2024 · 2c9b0ad · 2c9b0ad
1 parent c7b9c39
commit 2c9b0ad
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/cmd/main.go b/cmd/main.go
@@ -48,7 +48,7 @@ func main() {
 	}
 	log.Info("Located smbstatus", "path", loc, "version", ver)
 
-	err = metrics.RunSmbMetricsExporter(log)
+	err = metrics.RunSmbMetricsExporter(log, metrics.DefaultMetricsPort)
 	if err != nil {
 		os.Exit(1)
 	}

diff --git a/internal/metrics/exporter.go b/internal/metrics/exporter.go
@@ -63,8 +63,11 @@ func (sme *smbMetricsExporter) serve() error {
 
 // RunSmbMetricsExporter executes an HTTP server and exports SMB metrics to
 // Prometheus.
-func RunSmbMetricsExporter(log logr.Logger) error {
-	sme := newSmbMetricsExporter(log, DefaultMetricsPort)
+func RunSmbMetricsExporter(log logr.Logger, port int) error {
+	if port <= 0 {
+		port = DefaultMetricsPort
+	}
+	sme := newSmbMetricsExporter(log, port)
 	err := sme.init()
 	if err != nil {
 		return err