metrics extended #9
Conversation
| OpenedAt string `json:"opened_at"` | ||
| ShareMode SMBStatusOpenShareMode `json:"sharemode"` | ||
| AccessMask SMBStatusOpenAccessMask `json:"access_mask"` | ||
| OpLock SMBStatusOpenOpLock `json:"oplock"` |
There was a problem hiding this comment.
Do you have a plan to include leases section?
There was a problem hiding this comment.
Yes, absolutely. It is part of my TODO list, but for now I want a minimal viable set of metrics. Do you think leases should be part of it or may I defer it to next cycle?
There was a problem hiding this comment.
leases can be considered as an upgrade to oplocks. I could see oplocks(but not yet used) and thus the question. You may choose to drop oplocks or add leases alongside.
There was a problem hiding this comment.
Fair enough. I will add leases as part of this PR
There was a problem hiding this comment.
@anoopcs9 Added Lease entry (after OpLock). Please re-review.
synarete
force-pushed
the
ss-metrics-extended
branch
from
175e47e
to
02f8329
Compare
internal/metrics/smbstatus_test.go
Outdated
| @@ -602,3 +616,16 @@ func TestParseSMBStatusLocks(t *testing.T) { | |||
| assert.Equal(t, lock2.FileID.Inode, int64(52)) | |||
| assert.Equal(t, lock2.NumPendingDeletes, 2) | |||
| } | |||
|
|
|||
| func TestParseSMBStatusLease(t *testing.T) { | |||
There was a problem hiding this comment.
May be add a test for oplocks too?
There was a problem hiding this comment.
You are right -- I should have done so in the first place..
synarete
force-pushed
the
ss-metrics-extended
branch
from
02f8329
to
cb7f8b5
Compare
internal/metrics/smbstatus_test.go
Outdated
| assert.Equal(t, lease.Handle, false) | ||
| assert.Equal(t, lease.Read, false) | ||
| assert.Equal(t, lease.Write, false) | ||
| assert.Equal(t, lease.Text, "") |
There was a problem hiding this comment.
To cover other SMBStatusOpenOpLock types:
assert.Equal(t, oplock.Batch, true)
assert.Equal(t, oplock.LevelII, false)
assert.Equal(t, oplock.Text, "BATCH")
There was a problem hiding this comment.
If you meant to include the additional checks in the current PR itself I don't see it in the updated version.
synarete
force-pushed
the
ss-metrics-extended
branch
from
cb7f8b5
to
5c65869
Compare
synarete
force-pushed
the
ss-metrics-extended
branch
from
5c65869
to
53ad326
Compare
Add extra layer of JSON parsing for more file-grained details on currently open-files. In particular, parse access-modes. Signed-off-by: Shachar Sharon <[email protected]>
Provides two new metrics: number of total open-file in RO/RW modes. Uses the detailed SMB information provided by 'open_files' section per file. Signed-off-by: Shachar Sharon <[email protected]>
Define two distinct share counter-metrics: number of remote machines currently using a specific share and the number of distinct shares used by a specific remote machine (identified by IP-address). Signed-off-by: Shachar Sharon <[email protected]>
Ignore the special value of "IPC$" when collecting and exporting shares' metrics. Signed-off-by: Shachar Sharon <[email protected]>
synarete
force-pushed
the
ss-metrics-extended
branch
from
53ad326
to
4421fd1
Compare
Provide extra-fine metrics information. In particular,. parse the
open_filessection insmbstatus --jsonand provide more metrics on open files.