-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
performatic changes #8
Conversation
<script src="js/vendor/raphael-min.js"></script> | ||
<script src="js/vendor/g.raphael-min.js"></script> | ||
<script src="js/vendor/piechart.js"></script> | ||
<script src="js/main.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would loading them with the async
attribute work here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that would be the case, the page relies on the main.js to write most of it's content and each file must be loaded in order to work.
To what extent were the changes successful? |
I didn't understand your question. |
Do you have any numbers indicating an improvement? To what extent is it more efficient? |
Not a serious one, it's hard to measure async methods performance, it would require a test library. For the sake of my consciousness, I put a |
That sounds good, and the performance tweaks are reasonable. Thanks for the improvements! |
I've made some changes in the main.js aiming for a better perfomance in the page load.