Update TTKS tweak #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you undo the changes for translated modules? The community was polled about it and doesn't want that change. |
|
Sure. I should keep the vanilla modules though, right? I.e., the vanilla translated names of the vanilla modules in the current localization |
Fixes five bugs: * TTKS now interacts with all translated versions of the modules it looks for. * TTKS now check that every module of a given type has been solved instead of only one (for the "turn key after solving" conditions). * TTKS now plays the TTK strike sound and animation for an incorrect turn. * TTKS now moves one with a strike (when you turn the key) when it would have softlocked before. * TTKS now no longer lets you turn a key multiple times.
…ions of vanilla modules
samfundev
reviewed
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is incompatible with parts of PR 49 by eXish.
This one does everything that one does for TTKS, as well as a bit more.
The translations were added because of the January 5th update to this Russian mission pack which complains about TTKS not working with translated modules.
Fixes five bugs:
On Harmony vs Reflection:
Harmony is more correct and more compatible than reflection in this case. The runtime performance is slightly (although negligibly) better, but more importantly simply assigning to a KMSelectable's OnInteract can cause problems, especially since other mods occasionally add to that field.