Fix Elevator of Doom causing exceptions + various other tweaks #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tweaks assumed that all bombs ran will have a FloatingHoldable component, which Elevator of Doom does not.
eXish
changed the title
eXish
changed the title
eXish
changed the title
samfundev
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaks assumed that all bombs ran will have a FloatingHoldable component, which Elevator of Doom does not.
This fixes issue #55.
The old URL for Parallel Mazes has died, so this also replaces that with a working one.
Symbstructions has been fixed mod side, so this also removes that tweak.
Lastly, I noticed that vanilla needies log a pass from Tweaks every time they are done correctly, as seen in the image below. I assume this is intended behaviour and should be done for all needies. However, all passes are not logged by Tweaks on modded needies, as it seems that the OnPass method in BombComponent does not fire for ModNeedyComponent. This also fixes this by directly hooking into the KMNeedyModule OnPass instead.
