Fix FIR multiplication #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Icarus, iCE40 (Yosys/nextpnr), and Quartus/Cyclone II tools the bit extension happens before the multiply. Operand 1 0xabcd becomes 0x0000_0000_abcd Operand 2 0x1234 becomes 0x0000_0000_1234 To fit into 16x16 multiplier, other tools are truncating the less-significant bits, resulting in a 0x0000_0000 * 0x0000_0000 multiplicaton. An unfortunate side effect is that now addition is now actually occuring, my iCE40 designs no longer meet timing. A pipeline stage may have to be added, but I am not sure how to make that play nice with the BRAMs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Icarus, iCE40 (Yosys/nextpnr), and Quartus/Cyclone II tools the bit extension happens before the multiply.
Operand 1 0xabcd becomes 0x0000_0000_abcd
Operand 2 0x1234 becomes 0x0000_0000_1234
To fit into 16x16 multiplier, other tools are truncating the less-significant bits, resulting in a 0x0000_0000 * 0x0000_0000 multiplicaton.
An unfortunate side effect is that now addition is now actually occuring, my iCE40 designs no longer meet timing. A pipeline stage may have to be added, but I am not sure how to make that play nice with the BRAMs.