Skip to content

Commit

Permalink
- r multiple code_smells jekyll links
Browse files Browse the repository at this point in the history
Co-Authored-By: Nitsan Avni <[email protected]>
Co-Authored-By: Ron Heywood <[email protected]>
Co-Authored-By: Iván Fernández <[email protected]>
  • Loading branch information
4 people committed Feb 21, 2025
1 parent e6ac586 commit 6dec171
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions _learning_hours/code_reading/common_code_smells.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ Repeat with another code sample or however many you have time for.
You are hoping that they will find smells like these:

* Tennis1: [Long method]({% link _code_smells/long_function.md %}), [Bumpy Road]({% link _code_smells/bumpy_road.md %})
* Tennis2: [Duplicated code](/code_smells/duplicated_code.html)
* Tennis3: [Mysterious names](/code_smells/mysterious_name.html)
* Theatrical Players: [Variable with Long Scope](/code_smells/variable_with_long_scope.html), [Loop](/code_smells/loop.html)
* Gilded Rose: [Long function](/code_smells/long_function.html), [Bumpy Road]({% link _code_smells/bumpy_road.md %})
* Tennis2: [Duplicated code]({% link _code_smells/duplicated_code.md %})
* Tennis3: [Mysterious names]({% link _code_smells/mysterious_name.md %})
* Theatrical Players: [Variable with Long Scope]({% link _code_smells/variable_with_long_scope.md %}), [Loop]({% link _code_smells/loop.md %})
* Gilded Rose: [Long function]({% link _code_smells/long_function.md %}), [Bumpy Road]({% link _code_smells/bumpy_road.md %})

### What code smells does your production code often suffer from?
Are any of these smells common in your production code? Or are there other smells? Discuss in pairs and note down names of smells you have noticed in your production code. Collect the names on a shared whiteboard.
Expand Down
2 changes: 1 addition & 1 deletion _learning_hours/refactoring/parallel_change.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ Reference - Danilo Sato has published [an article](https://martinfowler.com/blik
### Concrete: Code Review
Ask everyone to take a look at this code: [Bingo Refactoring Kata](https://github.com/sammancoaching/Bingo-Refactoring-Kata). What code smells do they see (regardless of whether they can name them or not)? What would be a better structure?

You are hoping they will spot that there are [Data Clumps](/code_smells/data_clumps.html) and [Primitive Obsession](/code_smells/primitive_obsession.html) - in particular these primitives:
You are hoping they will spot that there are [Data Clumps]({% link _code_smells/data_clumps.md %}) and [Primitive Obsession]({% link _code_smells/primitive_obsession.md %}) - in particular these primitives:

String[][] cells
boolean[][] marked
Expand Down
4 changes: 2 additions & 2 deletions _learning_hours/refactoring/primitive_obsession.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ affiliation: Atruvia

# Primitive Obsession

It's useful to have a shared knowledge of different Code Smells and how to handle them. [Primitive Obsession](/code_smells/primitive_obsession.html) is a very common smell which occurs in projects.
It's useful to have a shared knowledge of different Code Smells and how to handle them. [Primitive Obsession]({% link _code_smells/primitive_obsession.md %}) is a very common smell which occurs in projects.
In this learning hour we will talk about what it is and how you are able to refactor it.

## Session Outline
Expand All @@ -25,7 +25,7 @@ In this learning hour we will talk about what it is and how you are able to refa
Everybody explains their own definition of a code smell.

### Concept: Primitive obsession
Explain [Primitive Obsession](/code_smells/primitive_obsession.html), for example:
Explain [Primitive Obsession]({% link _code_smells/primitive_obsession.md %}), for example:
- The excessive use of primitive data types instead of (small) objects
- The use of integers or enums to represent types of objects

Expand Down
2 changes: 1 addition & 1 deletion _refactorings/extract_function.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,4 @@ If that doesn't work, these are some manual steps:
* Inline method parameters if the previously extracted variables no longer make sense.

## Follow up
Consider if the new method has [Feature Envy](/code_smells/feature_envy.html) and if it should be moved somewhere else.
Consider if the new method has [Feature Envy]({% link _code_smells/feature_envy.md %}) and if it should be moved somewhere else.

0 comments on commit 6dec171

Please sign in to comment.