Objective-C: Fix memory leak in Patch (google/diff-match-patch#156)

Resolves google/diff-match-patch#156. The NSMutableArray being assigned to Patch.diffs isn't being autoreleased correctly. Since it's being assigned to a synthesized property marked with retain, and the NSMutableArray is being initialized with alloc-init, the array needs to be autoreleased so that it doesn't leak. See also Simperium/simperium-ios#89 Authored-by: Anthony Drendel <[email protected]>
samrayner · Mar 22, 2024 · 60a0b3d · 60a0b3d
1 parent 634e10f
commit 60a0b3d
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/objectivec/DiffMatchPatch.m b/objectivec/DiffMatchPatch.m
@@ -189,7 +189,7 @@ - (id)copyWithZone:(NSZone *)zone
 {
   Patch *newPatch = [[[self class] allocWithZone:zone] init];
 
-  newPatch.diffs = [[NSMutableArray alloc] initWithArray:self.diffs copyItems:YES];
+  newPatch.diffs = [[[NSMutableArray alloc] initWithArray:self.diffs copyItems:YES] autorelease];
   newPatch.start1 = self.start1;
   newPatch.start2 = self.start2;
   newPatch.length1 = self.length1;