Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: also handle SIGHUP in onInterruptSignal #69

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

johnwonkim
Copy link
Contributor

@johnwonkim johnwonkim commented Oct 25, 2023

onInterruptSignal is a function that accepts a cleanup function and
runs it on SIGINT and SIGTERM. Update to also run cleanup on SIGHUP.
Major use case is to handle broken SSH connections.

Tested using VSCode remote terminal and manual SSH over iTerm.

`onInterruptSignal` is a function that accepts a cleanup function and
runs it on SIGINT and SIGTERM. Update to also run cleanup on SIGHUP.
Major use case is to handle broken SSH connections.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6647327204

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 52.031%

Totals Coverage Status
Change from base Build 5348174734: 0.0%
Covered Lines: 730
Relevant Lines: 1403

💛 - Coveralls

@johnwonkim johnwonkim marked this pull request as ready for review October 26, 2023 17:23
@johnwonkim johnwonkim merged commit b358b1d into master Oct 26, 2023
3 checks passed
@johnwonkim johnwonkim deleted the johnkim/handle-sighup branch October 26, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants