Fix a few warnings and ensure polysomy is built in the CI tests #2307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These triggered a "variable is set but not used" warning when building with --enable-libgsl
These are probably false positives, but with low optimisation the compiler isn't able to work out that the variables are always set before use. Fix by always assigning them.
Add packages needed for these options and enable them on configure builds. The perl IO::Pty package is also added for Debian and Ubuntu so the usage tests work. Also adjust how flags are set in the CI builds to ensure they are applied consistently.
This is the only image currently supported by Cirrus-CI, which was automatically switching from the one requested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a couple of warnings that appeared when using
./configure --enable-libgslor with optimisation-Og. Also tidies up the CI builds a bit as compiler flags weren't being applied consistently, and updates the MacOS build to Sonoma.