Skip to content

Commit

Permalink
Remove the ".dirty" from htsjdk jar names
Browse files Browse the repository at this point in the history
The current build.gradle adds a ".dirty" to the jar name when
running "gradle jar" when there are untracked files, even if there
are no uncommitted changes and the working directory is otherwise
clean. This is misleading, since "dirty" implies that the build
contains uncommitted changes, but untracked files do not affect
the build at all. Rather than cause confusion, let's just strip
out ".dirty" from the name for now.
  • Loading branch information
droazen committed May 24, 2016
1 parent 72ae3f7 commit 841e47f
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ sourceCompatibility = 1.8
targetCompatibility = 1.8

final isRelease = Boolean.getBoolean("release")
version = isRelease ? gitVersion() : gitVersion() + "-SNAPSHOT"
final gitVersion = gitVersion().replaceAll(".dirty", "")
version = isRelease ? gitVersion : gitVersion + "-SNAPSHOT"

logger.info("build for version:" + version)
group = 'com.github.samtools'
Expand Down

0 comments on commit 841e47f

Please sign in to comment.