Skip to content

Commit

Permalink
🧹 Ensure feature specs run clean
Browse files Browse the repository at this point in the history
Prior to this commit, we did not automatically clean the features.  The
below ripgrep (and output) shows that there were some features which did
not start from a clean state.

```
rg "(clean|clean_repo):" spec/features --files-without-match
``

```
spec/features/accounts_spec.rb
spec/features/proprietor_spec.rb
spec/features/featured_collections_spec.rb
spec/features/user_roles_spec.rb
spec/features/oai_pmh_spec.rb
```
  • Loading branch information
jeremyf committed Dec 21, 2023
1 parent 28825f9 commit 0616ff2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion spec/rails_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@
ActiveFedora::SolrService.reset!
# Pass `:clean' (or hyrax's convention of :clean_repo) to destroy objects in fedora/solr and
# start from scratch
if example.metadata[:clean] || example.metadata[:clean_repo]
if example.metadata[:clean] || example.metadata[:clean_repo] || example.metadata[:type] == :feature
## We don't need to do `Hyrax::SolrService.wipe!` so long as we're using `ActiveFedora.clean!`;
## but Valkyrie is coming so be prepared.
# Hyrax::SolrService.wipe!
Expand Down

0 comments on commit 0616ff2

Please sign in to comment.