🧹 Fix button class for Bootstrap 3 to 4

samvera · Dec 21, 2023 · 7184607 · 7184607
1 parent 046c6ea
commit 7184607
Showing 1 changed file with 11 additions and 12 deletions.
diff --git a/spec/features/admin_set_form_participants_tab_spec.rb b/spec/features/admin_set_form_participants_tab_spec.rb
@@ -2,7 +2,7 @@
 
 require 'rails_helper'
 
-RSpec.describe 'AdminSet form Participants tab', type: :feature, js: true, clean: true, ci: 'skip' do
+RSpec.describe 'AdminSet form Participants tab', type: :feature, js: true, clean: true do
   include Warden::Test::Helpers
 
   context 'as an admin user' do
@@ -63,7 +63,7 @@
             text: group.humanized_name
           ).click
           find('select#permission_template_access_grants_attributes_0_access option', text: 'Manager').click
-          find('input.btn-info').click
+          find('input.btn-secondary').click
         end
 
         expect(find('table.managers-table')).to have_content(group.name.titleize)
@@ -86,7 +86,7 @@
             text: group.humanized_name
           ).click
           find('select#permission_template_access_grants_attributes_0_access option', text: 'Depositor').click
-          find('input.btn-info').click
+          find('input.btn-secondary').click
         end
 
         expect(find('table.managers-table')).not_to have_content(group.name.titleize)
@@ -109,7 +109,7 @@
             text: group.humanized_name
           ).click
           find('select#permission_template_access_grants_attributes_0_access option', text: 'Viewer').click
-          find('input.btn-info').click
+          find('input.btn-secondary').click
         end
 
         expect(find('table.managers-table')).not_to have_content(group.name.titleize)
@@ -136,10 +136,9 @@
                            .find(:xpath, '//td[@data-agent="admin"]')
                            .find(:xpath, '..')['innerHTML']
         expect(manager_row_html).to include('<td data-agent="admin">Repository Administrators</td>')
-        expect(manager_row_html).to include(
-          '<input class="btn btn-danger" disabled="disabled" ' \
-          'title="The repository administrators group cannot be removed" type="submit" value="Remove">'
-        )
+        # rubocop:disable Metrics/LineLength
+        expect(manager_row_html).to include('<input class="btn btn-sm btn-danger disabled" disabled="disabled" title="The repository administrators group cannot be removed" type="submit" value="Remove">')
+        # rubocop:enable Metrics/LineLength
       end
 
       it 'shows an enabled remove button next to Repository Administrator group as a Depositor' do
@@ -149,14 +148,14 @@
             text: "Repository Administrators"
           ).click
           find('select#permission_template_access_grants_attributes_0_access option', text: 'Depositor').click
-          find('input.btn-info').click
+          find('input.btn-secondary').click
         end
 
         depositor_row_html = find('table.depositors-table')
                              .find(:xpath, './/td[@data-agent="admin"]')
                              .find(:xpath, '..')['innerHTML']
         expect(depositor_row_html).to include('<td data-agent="admin">Repository Administrators</td>')
-        expect(depositor_row_html).to include('<input class="btn btn-danger" type="submit" value="Remove">')
+        expect(depositor_row_html).to include('<input class="btn btn-sm btn-danger" type="submit" value="Remove">')
       end
 
       it 'shows an enabled remove button next to Repository Administrator group as a Viewer' do
@@ -166,14 +165,14 @@
             text: "Repository Administrators"
           ).click
           find('select#permission_template_access_grants_attributes_0_access option', text: 'Viewer').click
-          find('input.btn-info').click
+          find('input.btn-secondary').click
         end
 
         viewer_row_html = find('table.viewers-table')
                           .find(:xpath, './/td[@data-agent="admin"]')
                           .find(:xpath, '..')['innerHTML']
         expect(viewer_row_html).to include('<td data-agent="admin">Repository Administrators</td>')
-        expect(viewer_row_html).to include('<input class="btn btn-danger" type="submit" value="Remove">')
+        expect(viewer_row_html).to include('<input class="btn btn-sm btn-danger" type="submit" value="Remove">')
       end
     end
   end