Remove obsolete site roles and routes

This is a WIP. The site/roles route is obsolete. This is an attempt to remove as much of the obsolete logic as possible, as it has been replaced by the groups with roles feature. There is some confusion about which pieces may still be in use, so further testing is needed to confirm that it doesn't remove anything necessary. There may be some unneeded remnants of prior roles logic in files such as users.rb or ability.rb but this attempt cleans out some of the lower-hanging fruit.
samvera · Dec 20, 2023 · b969dad · b969dad
1 parent b01e6c5
commit b969dad
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 187 deletions.
diff --git a/app/controllers/roles_controller.rb b/app/controllers/roles_controller.rb
diff --git a/app/views/roles/index.html.erb b/app/views/roles/index.html.erb
diff --git a/config/routes.rb b/config/routes.rb
@@ -43,7 +43,6 @@
 
   mount BrowseEverything::Engine => '/browse'
   resource :site, only: [:update] do
-    resources :roles, only: %i[index update]
     resource :labels, only: %i[edit update]
   end
 

diff --git a/spec/controllers/roles_controller_spec.rb b/spec/controllers/roles_controller_spec.rb
diff --git a/spec/features/roles_spec.rb b/spec/features/roles_spec.rb
diff --git a/spec/routing/roles_routing_spec.rb b/spec/routing/roles_routing_spec.rb