Hyrax 5 upgrade fix a few specs #2101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ady to the gem file and configure them
…amvera/hyku into mr_good_job_its_got_to_be_good
Just found one actor that was overriding Hyrax. This commit will switch it to a decorator.
…sibility 🧹 Fix `./spec/requests/admin_dashboard_spec.rb` spec
🧹 Clean up actors
🎁 Upgrade Redis initializer to Hyrax 5's gen version
Adjust paths and keys to look for labels.
The partials rendered in the tested view assume that we've set a collection type.
Hyrax 5 upgrade spec fixing
…oviders 🐛 Handle missing labels
…d-collections 🧹 Assigning collection_type
…-selectors Fixing nav link selectors to new structure
The only big thing in this commit is the appearance_decorator. I've added to the spec to show that the decorator should be working as intended.
…-selectors Fixing nav link selectors to new structure
🧹 Clean up forms
…-selectors Fixing nav link selectors to new structure
The selector was *very* specific, and with the HTML class changes for
Bootstrap 3 to 4, this almost certainly broke.
Note, there are still underlying issues with two other specs; there
errors are listed below:
```
1) Admin can select home page theme when a search results theme is
selected updates the search results page with the selected layout view
Failure/Error: super
ActionView::Template::Error:
undefined method `with_collection' for nil:NilClass
```
The hyper specific selectors are not durable for CSS framework upgrades.
🧹 Narrow specificity of CSS selector
houndci-bot
reviewed
Dec 21, 2023
| allColorInputs.each(function() { | ||
| $(this).val($(this).data('default-value')) | ||
| }) | ||
| }) |
|
|
||
| allColorInputs.each(function() { | ||
| $(this).val($(this).data('default-value')) | ||
| }) |
| var allColorInputs = $("input[name*='color']") | ||
|
|
||
| allColorInputs.each(function() { | ||
| $(this).val($(this).data('default-value')) |
| $('.panel-footer a.restore-all-default-colors').click(function(e) { | ||
| e.preventDefault() | ||
|
|
||
| var allColorInputs = $("input[name*='color']") |
| }) | ||
|
|
||
| $('.panel-footer a.restore-all-default-colors').click(function(e) { | ||
| e.preventDefault() |
| var input = $("input[name='admin_appearance["+ defaultTarget +"]']") | ||
|
|
||
| input.val(input.data('default-value')) | ||
| }) |
| var defaultTarget = $(e.target).data('default-target') | ||
| var input = $("input[name='admin_appearance["+ defaultTarget +"]']") | ||
|
|
||
| input.val(input.data('default-value')) |
| e.preventDefault() | ||
|
|
||
| var defaultTarget = $(e.target).data('default-target') | ||
| var input = $("input[name='admin_appearance["+ defaultTarget +"]']") |
| $('div.defaultable-colors a.restore-default-color').click(function(e) { | ||
| e.preventDefault() | ||
|
|
||
| var defaultTarget = $(e.target).data('default-target') |
| @@ -0,0 +1,20 @@ | |||
| $(document).on('turbolinks:load', function() { | |||
| $('div.defaultable-colors a.restore-default-color').click(function(e) { | |||
| e.preventDefault() | |||
houndci-bot
reviewed
Dec 21, 2023
| allColorInputs.each(function() { | ||
| $(this).val($(this).data('default-value')) | ||
| }) | ||
| }) |
|
|
||
| allColorInputs.each(function() { | ||
| $(this).val($(this).data('default-value')) | ||
| }) |
| var allColorInputs = $("input[name*='color']") | ||
|
|
||
| allColorInputs.each(function() { | ||
| $(this).val($(this).data('default-value')) |
| $('.panel-footer a.restore-all-default-colors').click(function(e) { | ||
| e.preventDefault() | ||
|
|
||
| var allColorInputs = $("input[name*='color']") |
| }) | ||
|
|
||
| $('.panel-footer a.restore-all-default-colors').click(function(e) { | ||
| e.preventDefault() |
| var input = $("input[name='admin_appearance["+ defaultTarget +"]']") | ||
|
|
||
| input.val(input.data('default-value')) | ||
| }) |
| var defaultTarget = $(e.target).data('default-target') | ||
| var input = $("input[name='admin_appearance["+ defaultTarget +"]']") | ||
|
|
||
| input.val(input.data('default-value')) |
| e.preventDefault() | ||
|
|
||
| var defaultTarget = $(e.target).data('default-target') | ||
| var input = $("input[name='admin_appearance["+ defaultTarget +"]']") |
| $('div.defaultable-colors a.restore-default-color').click(function(e) { | ||
| e.preventDefault() | ||
|
|
||
| var defaultTarget = $(e.target).data('default-target') |
| @@ -0,0 +1,20 @@ | |||
| $(document).on('turbolinks:load', function() { | |||
| $('div.defaultable-colors a.restore-default-color').click(function(e) { | |||
| e.preventDefault() | |||
houndci-bot
reviewed
Dec 21, 2023
| allColorInputs.each(function() { | ||
| $(this).val($(this).data('default-value')) | ||
| }) | ||
| }) |
|
|
||
| allColorInputs.each(function() { | ||
| $(this).val($(this).data('default-value')) | ||
| }) |
| var allColorInputs = $("input[name*='color']") | ||
|
|
||
| allColorInputs.each(function() { | ||
| $(this).val($(this).data('default-value')) |
| $('.panel-footer a.restore-all-default-colors').click(function(e) { | ||
| e.preventDefault() | ||
|
|
||
| var allColorInputs = $("input[name*='color']") |
| }) | ||
|
|
||
| $('.panel-footer a.restore-all-default-colors').click(function(e) { | ||
| e.preventDefault() |
| $('div.defaultable-colors a.restore-default-color').click(function(e) { | ||
| e.preventDefault() | ||
|
|
||
| var defaultTarget = $(e.target).data('default-target') |
| @@ -0,0 +1,20 @@ | |||
| $(document).on('turbolinks:load', function() { | |||
| $('div.defaultable-colors a.restore-default-color').click(function(e) { | |||
| e.preventDefault() | |||
| // Grab the data from the ul div | ||
| var series_data = new Array(); | ||
| var pointer_lookup = new Array(); | ||
| var x_ticks = new Array(); |
There was a problem hiding this comment.
The array literal notation [] is preferable.
| if (domDependenciesMet()) { | ||
| // Grab the data from the ul div | ||
| var series_data = new Array(); | ||
| var pointer_lookup = new Array(); |
There was a problem hiding this comment.
The array literal notation [] is preferable.
| //flot loaded? And canvas element supported. | ||
| if (domDependenciesMet()) { | ||
| // Grab the data from the ul div | ||
| var series_data = new Array(); |
There was a problem hiding this comment.
The array literal notation [] is preferable.
houndci-bot
reviewed
Dec 21, 2023
| allColorInputs.each(function() { | ||
| $(this).val($(this).data('default-value')) | ||
| }) | ||
| }) |
|
|
||
| allColorInputs.each(function() { | ||
| $(this).val($(this).data('default-value')) | ||
| }) |
| var allColorInputs = $("input[name*='color']") | ||
|
|
||
| allColorInputs.each(function() { | ||
| $(this).val($(this).data('default-value')) |
| $('.panel-footer a.restore-all-default-colors').click(function(e) { | ||
| e.preventDefault() | ||
|
|
||
| var allColorInputs = $("input[name*='color']") |
| }) | ||
|
|
||
| $('.panel-footer a.restore-all-default-colors').click(function(e) { | ||
| e.preventDefault() |
| @@ -0,0 +1,20 @@ | |||
| $(document).on('turbolinks:load', function() { | |||
| $('div.defaultable-colors a.restore-default-color').click(function(e) { | |||
| e.preventDefault() | |||
| // Grab the data from the ul div | ||
| var series_data = new Array(); | ||
| var pointer_lookup = new Array(); | ||
| var x_ticks = new Array(); |
There was a problem hiding this comment.
The array literal notation [] is preferable.
| if (domDependenciesMet()) { | ||
| // Grab the data from the ul div | ||
| var series_data = new Array(); | ||
| var pointer_lookup = new Array(); |
There was a problem hiding this comment.
The array literal notation [] is preferable.
| //flot loaded? And canvas element supported. | ||
| if (domDependenciesMet()) { | ||
| // Grab the data from the ul div | ||
| var series_data = new Array(); |
There was a problem hiding this comment.
The array literal notation [] is preferable.
| }; | ||
|
|
||
| global.BlacklightRangeLimit = BlacklightRangeLimit; | ||
| }(this); |
There was a problem hiding this comment.
Expected an assignment or function call and instead saw an expression.
houndci-bot
reviewed
Dec 21, 2023
| allColorInputs.each(function() { | ||
| $(this).val($(this).data('default-value')) | ||
| }) | ||
| }) |
|
|
||
| allColorInputs.each(function() { | ||
| $(this).val($(this).data('default-value')) | ||
| }) |
| var allColorInputs = $("input[name*='color']") | ||
|
|
||
| allColorInputs.each(function() { | ||
| $(this).val($(this).data('default-value')) |
| $('.panel-footer a.restore-all-default-colors').click(function(e) { | ||
| e.preventDefault() | ||
|
|
||
| var allColorInputs = $("input[name*='color']") |
| }) | ||
|
|
||
| $('.panel-footer a.restore-all-default-colors').click(function(e) { | ||
| e.preventDefault() |
| if (domDependenciesMet()) { | ||
| // Grab the data from the ul div | ||
| var series_data = new Array(); | ||
| var pointer_lookup = new Array(); |
There was a problem hiding this comment.
The array literal notation [] is preferable.
| //flot loaded? And canvas element supported. | ||
| if (domDependenciesMet()) { | ||
| // Grab the data from the ul div | ||
| var series_data = new Array(); |
There was a problem hiding this comment.
The array literal notation [] is preferable.
| }; | ||
|
|
||
| global.BlacklightRangeLimit = BlacklightRangeLimit; | ||
| }(this); |
There was a problem hiding this comment.
Expected an assignment or function call and instead saw an expression.
| max = BlacklightRangeLimit.parseNum($(range_element).find(".max").first().text()); | ||
| } | ||
|
|
||
| return [min, max] |
|
|
||
|
|
||
|
|
||
| var min = max = BlacklightRangeLimit.parseNum(current_limit.find(".single").text()) |
There was a problem hiding this comment.
Missing semicolon.
You might be leaking a variable (max) here.
houndci-bot
reviewed
Dec 21, 2023
| // set as sniffed from HTML. Pass in a DOM element for a div.range | ||
| // Will return NaN as min or max in case of error or other weirdness. | ||
| function min_max(range_element) { | ||
| var current_limit = $(range_element).closest(".limit_content.range_limit").find(".current") |
|
|
||
| if (plot && slider_el) { | ||
| slider_el.width(plot.width()); | ||
| slider_el.css("display", "block") |
| placeholder_input.slider("setValue", values); | ||
| }); | ||
|
|
||
| end_el.change( function() { |
| begin_el.val(min); | ||
| end_el.val(max); | ||
|
|
||
| begin_el.change( function() { |
| } | ||
|
|
||
| begin_el.val(min); | ||
| end_el.val(max); |
| }); | ||
| } | ||
|
|
||
| begin_el.val(min); |
|
|
||
| // Slider change should update text input values. | ||
| var parent = $(this).parent(); | ||
| var form = $(parent).closest(".limit_content").find("form.range_limit"); |
|
|
||
| if (plot && slider_el) { | ||
| slider_el.width(plot.width()); | ||
| slider_el.css("display", "block") |
| if (isInt(min) && isInt(max)) { | ||
| $(this).contents().wrapAll('<div style="display:none" />'); | ||
|
|
||
| var range_element = $(this); |
There was a problem hiding this comment.
'range_element' is already defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧹 Narrow specificity of CSS selector
cffe41b
The selector was very specific, and with the HTML class changes for
Bootstrap 3 to 4, this almost certainly broke.
Note, there are still underlying issues with two other specs; there
errors are listed below:
🧹 Remove specificity of CSS selectors in test
9c3c46a
The hyper specific selectors are not durable for CSS framework upgrades.