-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
☄️ Valkyrize Hyku EPIC #2129
☄️ Valkyrize Hyku EPIC #2129
Changes from all commits
28e31ae
963fda8
db7e39d
44aa7f7
887fbf2
4322d9c
c7ac8d6
89d0c59
9be2b81
e05e5c1
fc72267
670784d
4622fa8
57616a8
2870a51
78db82f
adb7393
9fdd797
c694ce0
d68d78e
3ac6ca9
aa25008
3e27770
9e82fde
ac313c7
f3c1c67
78d26c5
60e097e
e21d98e
63aa39c
4123e38
bb112d0
dd61e0c
54f8d1f
3459609
7b2f3b3
89df09e
6516b00
7b32e43
11ed1b0
14a33e7
0b13c46
093c404
f99eb6f
544b64f
ec12d8b
683e4d4
ecfe4a4
a4d3125
d30ae50
88d4cce
5c0ac17
6084d80
fc45945
5f70ffb
bfa71b7
51bf79b
a0d1013
f0329f3
8016058
38ceb5d
818cdbc
6a065dd
83738e1
05ff3be
ee2e5be
a7e3ac4
02d8ef0
683311c
9167757
9c3af9e
d02aa82
ea7a714
bd301a2
d6fa335
35286c3
2a32321
6bac079
bedc3ad
c4b0c9e
95436af
a160896
2d2f1d4
c337df9
16ef18a
b96c954
2fbffd8
69cd025
afaf1a0
59dbce3
90abb58
a99685d
b911729
173053f
4f372ec
d90ed63
67834dd
91368ee
bf5f51b
5a8430b
7f12d48
c106563
b53c20f
3d2b85a
c3e9c88
88edd03
cf30c3e
fc4118a
9de1b88
081378d
d53ac06
a6f1316
2bba104
c3ab645
34bfb28
08eadab
d164944
ff50f74
848a270
c1ab0e7
244898b
62bb52c
44ee888
3660d46
275e22b
39c304f
61ad72e
d9dccb4
6dd7401
82816af
da05047
e4167d4
628e5b6
5068597
f118fbf
36db042
4937da0
15ec554
f4ca845
3dcbcf5
6891776
e1726df
cb576e2
b7d2a37
0f76a4e
8487114
4d98b70
5ca533f
39a13d5
f9fffdb
348c5a5
e7d82ee
b9465cf
3936726
5680a18
5227adb
7377572
ca9d5ab
54d0a42
917b2ce
ee48b61
1824bc8
4968242
c66ba49
e581054
e04a9c5
85772d7
17c2fc7
4fd3954
389e953
649acac
f59f070
b5e74b7
3d7de4e
404f0c3
c80cff6
68f1750
21d8e70
bc596c0
e138418
d0c7832
dcbceab
7c9cb22
b21c477
89c5741
7a9b7b8
1778bab
92045f9
f4e2732
9072bac
8d56979
b0cbbac
ff0a912
c66865a
a5771f8
17dea1b
47cbfbd
6a4f1e5
659d60c
66e9831
4ac5e1e
48133b1
1cd5ca1
da5c523
3749af5
c9c1185
e7718b2
f41ba15
61c863d
05fd2eb
d1d11bc
d0e27dc
3fbf2f4
06350fc
4375a29
29ef204
37b16e0
fc85d08
7ff49ca
0642931
d87e4ed
ae46a17
9614850
a327222
6940b4c
29963d3
1512867
a32664d
5542205
f0f5421
cfa48b4
093251b
75a9d99
65c9abb
fb6adf7
5e97d78
5b61235
d3df1e0
5a90fcf
2ec7b41
a8c49fd
8cf0e95
ad48579
f745207
289ca62
08779c1
19e5f3a
25f22cc
a19960f
8e390ee
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,6 +16,10 @@ | |
} | ||
} | ||
|
||
.dashboard .form-tab-content label { | ||
font-weight: 700; | ||
} | ||
|
||
@media (min-width: 768px) { | ||
.logo-set { | ||
display: flex; | ||
|
@@ -467,6 +471,24 @@ body.public-facing { | |
padding: 0; | ||
} | ||
|
||
.dd3-handle { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Rule set contains (17/10) properties |
||
position: absolute; margin: 0; left: 0; top: 0; cursor: pointer; width: 30px; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Properties should be ordered background, border, border-bottom-right-radius, border-top-right-radius, cursor, left, margin, overflow, position, text-indent, top, white-space, width, z-index |
||
text-indent: 100px; | ||
white-space: nowrap; overflow: hidden; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Property 'overflow' should be placed on own line |
||
border: 1px solid #aaa; | ||
background: #ddd; | ||
background: -webkit-linear-gradient(top, #ddd 0%, #bbb 100%); | ||
background: -moz-linear-gradient(top, #ddd 0%, #bbb 100%); | ||
background: linear-gradient(top, #ddd 0%, #bbb 100%); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Property |
||
border-top-right-radius: 0; | ||
border-bottom-right-radius: 0; | ||
z-index: 1; | ||
} | ||
|
||
.dd3-content .card-body { | ||
background: transparent; | ||
} | ||
|
||
.d-flex { | ||
display: flex; | ||
} | ||
|
@@ -532,6 +554,7 @@ span.constraint-value p, .facet-values p { | |
// style the analytics button to match citations button | ||
#stats { | ||
margin-top: 10px; | ||
|
||
@media (min-width: 576px) { | ||
max-width: 300px; | ||
} | ||
|
@@ -549,25 +572,28 @@ span.constraint-value p, .facet-values p { | |
// collection show page styles | ||
|
||
.space-between { | ||
justify-content: space-between; | ||
align-items: center; | ||
justify-content: space-between; | ||
} | ||
|
||
.hyc-banner { | ||
padding: 15px; | ||
.hyc-bugs .hyc-created-by, .hyc-bugs .hyc-last-updated, .hyc-title { | ||
.hyc-bugs .hyc-created-by, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Rule declaration should be preceded by an empty line |
||
.hyc-bugs .hyc-last-updated, | ||
.hyc-title { | ||
padding: 0; | ||
} | ||
|
||
.hyc-item-count { | ||
margin: 0; | ||
background: rgba(255, 255, 255, 0.75); | ||
padding: 10px; | ||
border-radius: 0.5em; | ||
color: #333; | ||
margin: 0; | ||
padding: 10px; | ||
} | ||
|
||
.hyc-bugs div, div { | ||
.hyc-bugs div, | ||
div { | ||
position: relative; | ||
} | ||
} | ||
|
@@ -588,7 +614,7 @@ span.constraint-value p, .facet-values p { | |
} | ||
|
||
.mb-2 { | ||
margin-bottom: .5em; | ||
margin-bottom: 0.5em; | ||
} | ||
|
||
.mb-5 { | ||
|
@@ -605,13 +631,13 @@ span.constraint-value p, .facet-values p { | |
} | ||
|
||
.py-0 { | ||
padding-top: 0; | ||
padding-bottom: 0; | ||
padding-top: 0; | ||
} | ||
|
||
.py-4 { | ||
padding-top: 2em; | ||
padding-bottom: 2em; | ||
padding-top: 2em; | ||
} | ||
|
||
.d-block { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,6 +22,6 @@ | |
|
||
// for catalog search result snippets | ||
.highlight { | ||
background: yellow; | ||
background: #ffff00; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Line should be indented 2 spaces, but was indented 4 spaces |
||
font-weight: 700; | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,4 +22,4 @@ | |
.video-embed-viewer { | ||
aspect-ratio: 16 / 9; | ||
width: 100%; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how did sentry become a hyku dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it not be? We added sentry for hyku up knapsack and knapsack prime, but now that you question it I wonder if we should've added it to bundler.d instead (within each repo)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: rip it out of hyku and put it in bundler.d of the respective repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to have come about because we added sentry (et al) to the gem spec of knapsack; and when we bundled along came sentry. This is definitely a surprise as we think about traditional directional dependencies; that is we think of Knapsack as laying on top of Hyku; but in reality it's a much more convoluted relationship.