Valkyrize the reindexer jobs #2147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShanaLMoore
reviewed
Jan 17, 2024
| @@ -2,6 +2,6 @@ | |||
|
|
|||
| class ReindexItemJob < ApplicationJob | |||
| def perform(item) | |||
| item.update_index | |||
| Hyrax.index_adapter.save(resource: item) | |||
There was a problem hiding this comment.
Suggested change
| Hyrax.index_adapter.save(resource: item) | |
| Hyrax.query_service.find_all_of_model(model: item.class).each do |resource| | |
| Hyrax.index_adapter.save(resource: item) | |
| end |
Should this turn into the above, based on our convo with Rob? Would this work if there are existing active fedora objects?
There was a problem hiding this comment.
I have to blow away my env to confirm ^^ checking now though...
There was a problem hiding this comment.
this was the error i received:
ShanaLMoore
approved these changes
Jan 17, 2024
| @@ -2,6 +2,6 @@ | |||
|
|
|||
| class ReindexItemJob < ApplicationJob | |||
| def perform(item) | |||
| item.update_index | |||
| Hyrax.index_adapter.save(resource: item) | |||
There was a problem hiding this comment.
I have to blow away my env to confirm ^^ checking now though...
laritakr
commented
Feb 1, 2024
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| class ReindexCollectionsJob < ApplicationJob | |||
| def perform | |||
| Collection.find_each do |collection| | |||
| PcdmCollection.find_each do |collection| | |||
There was a problem hiding this comment.
This needs to be changed to use the config collection class. Possibly should also reference multiple models?
laritakr
commented
Feb 1, 2024
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| class ReindexAdminSetsJob < ApplicationJob | |||
| def perform | |||
| AdminSet.find_each(&:update_index) | |||
| AdministrativeSet.find_each do |admin_set| | |||
There was a problem hiding this comment.
This needs to be changed to use the config admin set class. Possibly should also reference multiple models?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref scientist-softserv/hykuup_knapsack#35
The current reindex wouldn't work for Valkyrie resources. However this change only picks up the new collection types, ignoring the ActiveFedora types.
Starting this as a draft to note the need for SOME change, even though this may not be adequate.