-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public facing collections show page styling #2345
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AKFosterDev
changed the title
Collections show page styling
DRAFT: Collections show page styling
Sep 24, 2024
AKFosterDev
requested review from
kirkkwang
and removed request for
ShanaLMoore
September 24, 2024 17:51
AKFosterDev
changed the title
DRAFT: Collections show page styling
DRAFT: Public facing collections show page styling
Sep 24, 2024
AKFosterDev
changed the title
DRAFT: Public facing collections show page styling
Public facing collections show page styling
Sep 24, 2024
kirkkwang
approved these changes
Sep 24, 2024
7 tasks
Test Results 3 files ±0 3 suites ±0 18m 10s ⏱️ +6s Results for commit 033b603. ± Comparison against base commit 394fc04. This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates styling for the public facing collections show page. It addresses the top bars, the gallery view and pagination issues.
Related Ticket
Pals #137
Screenshots