Use fixtures :all to ensure consistent test data and improve test r…

…eliability (#41961). Patch by Katsuya HIDAKA (user:hidakatsuya). git-svn-id: https://svn.redmine.org/redmine/trunk@23391 e93f8b46-1217-0410-a6f0-8f06a7374b81
sanak · Dec 11, 2024 · 4fb1e4b · 4fb1e4b
1 parent 7ae0427
commit 4fb1e4b
Show file tree

Hide file tree

Showing 241 changed files with 2 additions and 1,378 deletions.
diff --git a/test/extra/redmine_pm/repository_git_test_pm.rb b/test/extra/redmine_pm/repository_git_test_pm.rb
@@ -21,8 +21,6 @@
 require 'tmpdir'
 
 class RedminePmTest::RepositoryGitTest < RedminePmTest::TestCase
-  fixtures :projects, :users, :members, :roles, :member_roles
-
   GIT_BIN = Redmine::Configuration['scm_git_command'] || "git"
 
   def test_anonymous_read_on_public_repo_with_permission_should_succeed

diff --git a/test/extra/redmine_pm/repository_subversion_test_pm.rb b/test/extra/redmine_pm/repository_subversion_test_pm.rb
@@ -21,8 +21,6 @@
 require 'tmpdir'
 
 class RedminePmTest::RepositorySubversionTest < RedminePmTest::TestCase
-  fixtures :projects, :users, :members, :roles, :member_roles, :auth_sources, :enabled_modules
-
   SVN_BIN = Redmine::Configuration['scm_subversion_command'] || "svn"
 
   def test_anonymous_read_on_public_repo_with_permission_should_succeed

diff --git a/test/functional/account_controller_test.rb b/test/functional/account_controller_test.rb
@@ -20,8 +20,6 @@
 require_relative '../test_helper'
 
 class AccountControllerTest < Redmine::ControllerTest
-  fixtures :users, :email_addresses, :roles
-
   def setup
     User.current = nil
   end

diff --git a/test/functional/activities_controller_test.rb b/test/functional/activities_controller_test.rb
@@ -20,17 +20,6 @@
 require_relative '../test_helper'
 
 class ActivitiesControllerTest < Redmine::ControllerTest
-  fixtures :projects, :trackers, :issue_statuses, :issues,
-           :enumerations, :users, :issue_categories,
-           :projects_trackers,
-           :roles,
-           :member_roles,
-           :members,
-           :groups_users,
-           :enabled_modules,
-           :journals, :journal_details,
-           :attachments, :changesets, :documents, :messages, :news, :time_entries, :wiki_content_versions
-
   def test_project_index
     get(
       :index,

diff --git a/test/functional/admin_controller_test.rb b/test/functional/admin_controller_test.rb
@@ -20,8 +20,6 @@
 require_relative '../test_helper'
 
 class AdminControllerTest < Redmine::ControllerTest
-  fixtures :projects, :users, :email_addresses, :roles
-
   def setup
     User.current = nil
     @request.session[:user_id] = 1 # admin

diff --git a/test/functional/attachments_controller_test.rb b/test/functional/attachments_controller_test.rb
@@ -20,10 +20,6 @@
 require_relative '../test_helper'
 
 class AttachmentsControllerTest < Redmine::ControllerTest
-  fixtures :users, :user_preferences, :projects, :roles, :members, :member_roles,
-           :enabled_modules, :issues, :trackers, :attachments, :issue_statuses, :journals, :journal_details,
-           :versions, :wiki_pages, :wikis, :documents, :enumerations
-
   def setup
     User.current = nil
     set_fixtures_attachments_directory

diff --git a/test/functional/attachments_visibility_test.rb b/test/functional/attachments_visibility_test.rb
@@ -21,11 +21,6 @@
 
 class AttachmentsVisibilityTest < Redmine::ControllerTest
   tests AttachmentsController
-  fixtures :users, :email_addresses, :projects, :roles, :members, :member_roles,
-           :enabled_modules, :projects_trackers, :issue_statuses, :enumerations,
-           :issues, :trackers, :versions,
-           :custom_fields, :custom_fields_trackers, :custom_fields_projects
-
   def setup
     User.current = nil
     set_tmp_attachments_directory

diff --git a/test/functional/auth_sources_controller_test.rb b/test/functional/auth_sources_controller_test.rb
@@ -20,8 +20,6 @@
 require_relative '../test_helper'
 
 class AuthSourcesControllerTest < Redmine::ControllerTest
-  fixtures :users, :auth_sources
-
   def setup
     @request.session[:user_id] = 1
   end

diff --git a/test/functional/auto_completes_controller_test.rb b/test/functional/auto_completes_controller_test.rb
@@ -20,17 +20,6 @@
 require_relative '../test_helper'
 
 class AutoCompletesControllerTest < Redmine::ControllerTest
-  fixtures :projects, :issues, :issue_statuses,
-           :enumerations, :users, :issue_categories,
-           :trackers,
-           :projects_trackers,
-           :roles,
-           :member_roles,
-           :members,
-           :enabled_modules,
-           :journals, :journal_details,
-           :wikis, :wiki_pages, :wiki_contents, :wiki_content_versions
-
   def test_issues_should_not_be_case_sensitive
     get(
       :issues,

diff --git a/test/functional/boards_controller_test.rb b/test/functional/boards_controller_test.rb
@@ -20,8 +20,6 @@
 require_relative '../test_helper'
 
 class BoardsControllerTest < Redmine::ControllerTest
-  fixtures :projects, :users, :members, :member_roles, :roles, :boards, :messages, :enabled_modules
-
   def setup
     User.current = nil
   end

diff --git a/test/functional/calendars_controller_test.rb b/test/functional/calendars_controller_test.rb
@@ -20,22 +20,6 @@
 require_relative '../test_helper'
 
 class CalendarsControllerTest < Redmine::ControllerTest
-  fixtures :projects,
-           :trackers,
-           :projects_trackers,
-           :roles,
-           :member_roles,
-           :members,
-           :enabled_modules,
-           :issues,
-           :issue_statuses,
-           :issue_relations,
-           :issue_categories,
-           :enumerations,
-           :queries,
-           :users, :email_addresses,
-           :versions
-
   def test_show
     # Ensure that an issue to which a user is assigned is in the current
     # month's calendar in order to test Gravatar

diff --git a/test/functional/comments_controller_test.rb b/test/functional/comments_controller_test.rb
@@ -20,8 +20,6 @@
 require_relative '../test_helper'
 
 class CommentsControllerTest < Redmine::ControllerTest
-  fixtures :projects, :users, :email_addresses, :roles, :members, :member_roles, :enabled_modules, :news, :comments
-
   def setup
     User.current = nil
   end

diff --git a/test/functional/context_menus_controller_test.rb b/test/functional/context_menus_controller_test.rb
@@ -20,22 +20,6 @@
 require_relative '../test_helper'
 
 class ContextMenusControllerTest < Redmine::ControllerTest
-  fixtures :projects,
-           :trackers,
-           :projects_trackers,
-           :roles,
-           :member_roles,
-           :members,
-           :enabled_modules,
-           :workflows,
-           :journals, :journal_details,
-           :versions,
-           :issues, :issue_statuses, :issue_categories,
-           :users,
-           :enumerations,
-           :time_entries,
-           :custom_fields, :custom_fields_trackers, :custom_fields_projects
-
   def test_context_menu_one_issue_should_link_to_issue_path
     @request.session[:user_id] = 2
     get(

diff --git a/test/functional/custom_field_enumerations_controller_test.rb b/test/functional/custom_field_enumerations_controller_test.rb
@@ -20,8 +20,6 @@
 require_relative '../test_helper'
 
 class CustomFieldEnumerationsControllerTest < Redmine::ControllerTest
-  fixtures :users, :email_addresses
-
   def setup
     @request.session[:user_id] = 1
     @field = GroupCustomField.create!(:name => 'List', :field_format => 'enumeration', :is_required => false)

diff --git a/test/functional/custom_fields_controller_test.rb b/test/functional/custom_fields_controller_test.rb
@@ -20,19 +20,6 @@
 require_relative '../test_helper'
 
 class CustomFieldsControllerTest < Redmine::ControllerTest
-  fixtures :custom_fields, :custom_values,
-           :custom_fields_projects, :custom_fields_trackers,
-           :roles, :users,
-           :members, :member_roles,
-           :groups_users,
-           :trackers, :projects_trackers,
-           :enabled_modules,
-           :projects, :issues,
-           :issue_statuses,
-           :issue_categories,
-           :enumerations,
-           :workflows
-
   def setup
     @request.session[:user_id] = 1
   end

diff --git a/test/functional/documents_controller_test.rb b/test/functional/documents_controller_test.rb
@@ -20,10 +20,6 @@
 require_relative '../test_helper'
 
 class DocumentsControllerTest < Redmine::ControllerTest
-  fixtures :projects, :users, :email_addresses, :roles, :members, :member_roles,
-           :enabled_modules, :documents, :enumerations,
-           :groups_users, :attachments, :user_preferences
-
   def setup
     User.current = nil
   end

diff --git a/test/functional/email_addresses_controller_test.rb b/test/functional/email_addresses_controller_test.rb
@@ -20,8 +20,6 @@
 require_relative '../test_helper'
 
 class EmailAddressesControllerTest < Redmine::ControllerTest
-  fixtures :users, :email_addresses
-
   def setup
     User.current = nil
   end

diff --git a/test/functional/enumerations_controller_test.rb b/test/functional/enumerations_controller_test.rb
@@ -20,8 +20,6 @@
 require_relative '../test_helper'
 
 class EnumerationsControllerTest < Redmine::ControllerTest
-  fixtures :enumerations, :issues, :users
-
   def setup
     @request.session[:user_id] = 1 # admin
   end

diff --git a/test/functional/files_controller_test.rb b/test/functional/files_controller_test.rb
@@ -20,19 +20,6 @@
 require_relative '../test_helper'
 
 class FilesControllerTest < Redmine::ControllerTest
-  fixtures :projects, :trackers, :issue_statuses, :issues,
-           :enumerations, :users,
-           :email_addresses,
-           :issue_categories,
-           :projects_trackers,
-           :roles,
-           :member_roles,
-           :members,
-           :enabled_modules,
-           :journals, :journal_details,
-           :attachments,
-           :versions
-
   def setup
     @request.session[:user_id] = nil
     Setting.default_language = 'en'

diff --git a/test/functional/gantts_controller_test.rb b/test/functional/gantts_controller_test.rb
@@ -20,16 +20,6 @@
 require_relative '../test_helper'
 
 class GanttsControllerTest < Redmine::ControllerTest
-  fixtures :projects, :trackers, :issue_statuses, :issues,
-           :enumerations, :users, :issue_categories,
-           :projects_trackers,
-           :roles,
-           :member_roles,
-           :members,
-           :enabled_modules,
-           :versions,
-           :email_addresses
-
   def test_gantt_should_work
     i2 = Issue.find(2)
     i2.update_attribute(:due_date, 1.month.from_now)

diff --git a/test/functional/groups_controller_test.rb b/test/functional/groups_controller_test.rb
@@ -20,8 +20,6 @@
 require_relative '../test_helper'
 
 class GroupsControllerTest < Redmine::ControllerTest
-  fixtures :projects, :users, :members, :member_roles, :roles, :groups_users
-
   def setup
     @request.session[:user_id] = 1
   end

diff --git a/test/functional/help_controller_test.rb b/test/functional/help_controller_test.rb
@@ -20,8 +20,6 @@
 require_relative '../test_helper'
 
 class HelpControllerTest < Redmine::ControllerTest
-  fixtures :users, :email_addresses
-
   def test_get_help_wiki_syntax
     formatters = {
       :textile => "Wiki Syntax Quick Reference",

diff --git a/test/functional/imports_controller_test.rb b/test/functional/imports_controller_test.rb
@@ -20,20 +20,6 @@
 require_relative '../test_helper'
 
 class ImportsControllerTest < Redmine::ControllerTest
-  fixtures :projects, :enabled_modules,
-           :users, :email_addresses, :user_preferences,
-           :roles, :members, :member_roles,
-           :issues, :issue_statuses,
-           :trackers, :projects_trackers,
-           :versions,
-           :issue_categories,
-           :enumerations,
-           :workflows,
-           :custom_fields,
-           :custom_values,
-           :custom_fields_projects,
-           :custom_fields_trackers
-
   include Redmine::I18n
 
   def setup

diff --git a/test/functional/issue_categories_controller_test.rb b/test/functional/issue_categories_controller_test.rb
@@ -20,9 +20,6 @@
 require_relative '../test_helper'
 
 class IssueCategoriesControllerTest < Redmine::ControllerTest
-  fixtures :projects, :users, :members, :member_roles, :roles, :enabled_modules, :issue_categories,
-           :issues
-
   def setup
     User.current = nil
     @request.session[:user_id] = 2

diff --git a/test/functional/issue_relations_controller_test.rb b/test/functional/issue_relations_controller_test.rb
@@ -20,19 +20,6 @@
 require_relative '../test_helper'
 
 class IssueRelationsControllerTest < Redmine::ControllerTest
-  fixtures :projects,
-           :users,
-           :roles,
-           :members,
-           :member_roles,
-           :issues,
-           :issue_statuses,
-           :issue_relations,
-           :enabled_modules,
-           :enumerations,
-           :trackers,
-           :projects_trackers
-
   def setup
     User.current = nil
     @request.session[:user_id] = 3

diff --git a/test/functional/issue_statuses_controller_test.rb b/test/functional/issue_statuses_controller_test.rb
@@ -20,8 +20,6 @@
 require_relative '../test_helper'
 
 class IssueStatusesControllerTest < Redmine::ControllerTest
-  fixtures :issue_statuses, :issues, :users, :trackers, :workflows
-
   def setup
     User.current = nil
     @request.session[:user_id] = 1 # admin

diff --git a/test/functional/issues_controller_test.rb b/test/functional/issues_controller_test.rb
@@ -20,34 +20,6 @@
 require_relative '../test_helper'
 
 class IssuesControllerTest < Redmine::ControllerTest
-  fixtures :projects,
-           :users, :email_addresses, :user_preferences,
-           :roles,
-           :members,
-           :member_roles,
-           :issues,
-           :issue_statuses,
-           :issue_relations,
-           :versions,
-           :trackers,
-           :projects_trackers,
-           :issue_categories,
-           :enabled_modules,
-           :enumerations,
-           :attachments,
-           :workflows,
-           :custom_fields,
-           :custom_values,
-           :custom_fields_projects,
-           :custom_fields_trackers,
-           :time_entries,
-           :journals,
-           :journal_details,
-           :queries,
-           :repositories,
-           :changesets,
-           :watchers, :groups_users
-
   include Redmine::I18n
 
   def setup