Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add various settings #183

Merged
merged 9 commits into from
Sep 8, 2024
Merged

Add various settings #183

merged 9 commits into from
Sep 8, 2024

Conversation

zihu12
Copy link
Contributor

@zihu12 zihu12 commented Aug 25, 2024

Progresses #111

Add BlockNetworkFiles,PromptForFileMigration,SbieCtrl_HideMessage and ShowForRunIn

@isaak654 isaak654 requested a review from offhub August 27, 2024 11:43
Co-authored-by: isaak654 <[email protected]>
@zihu12 zihu12 requested a review from isaak654 September 7, 2024 12:52

The first parameter is mandatory, specifies the id of the SBIE Messages to be hidden.

The second parameter is optional, displayed as "Message Text" in UI. Notice: Even if this is configured, All messages of such will be hidden regardless of its text.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The second parameter is optional, displayed as "Message Text" in UI. Notice: Even if this is configured, All messages of such will be hidden regardless of its text.
The second parameter is optional, displayed as "Message Text" in UI.

I have doubts about the second sentence. Does it mean that there is no point in setting the second parameter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you set it it will be shown in GUI, not if not set, see image attached:
image

Copy link
Contributor Author

@zihu12 zihu12 Sep 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the second parameter may be regarded useless considering all messages of this id will be hidden

In sbie plus it seems not the case?
image

Copy link
Contributor Author

@zihu12 zihu12 Sep 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some changes considering this situation.
Also checked all messages of the instance will be hidden if second parameter is not set.

Copy link
Contributor Author

@zihu12 zihu12 Sep 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

So we maybe change the text info of sbie plus gui as well?
(Agreeing to this prompt will set the text along with the ID

Co-authored-by: isaak654 <[email protected]>
@isaak654 isaak654 changed the title Add various sandbox ini parameters Add various settings Sep 7, 2024
@isaak654 isaak654 merged commit 824b4a7 into sandboxie-plus:main Sep 8, 2024
1 check passed
@zihu12 zihu12 deleted the patch-1 branch September 16, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants