-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add various settings #183
Add various settings #183
Conversation
Co-authored-by: isaak654 <[email protected]>
Co-authored-by: isaak654 <[email protected]>
docs/Content/SbieCtrl_HideMessage.md
Outdated
|
||
The first parameter is mandatory, specifies the id of the SBIE Messages to be hidden. | ||
|
||
The second parameter is optional, displayed as "Message Text" in UI. Notice: Even if this is configured, All messages of such will be hidden regardless of its text. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second parameter is optional, displayed as "Message Text" in UI. Notice: Even if this is configured, All messages of such will be hidden regardless of its text. | |
The second parameter is optional, displayed as "Message Text" in UI. |
I have doubts about the second sentence. Does it mean that there is no point in setting the second parameter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes the second parameter may be regarded useless considering all messages of this id will be hidden
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did some changes considering this situation.
Also checked all messages of the instance will be hidden if second parameter is not set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: isaak654 <[email protected]>
Co-authored-by: isaak654 <[email protected]>
Co-authored-by: isaak654 <[email protected]>
Co-authored-by: isaak654 <[email protected]>
Co-authored-by: isaak654 <[email protected]>
Progresses #111
Add
BlockNetworkFiles
,PromptForFileMigration
,SbieCtrl_HideMessage
andShowForRunIn