Allow setting MCP2515 mask and filter registers directly, as well as control rollover #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gisters directly, as well as control rollover This provides a much greater flexibility than just one mask and filter pair. While at it, fix incorrect REG_RXFn* macros, and add TODOs for a couple more places in the code related to filtering that seem to violate the datasheet.
catphish
reviewed
Oct 20, 2021
Comment on lines
+293
to
+295
| // TODO: This doesn't look correct. According to the datasheet, the RXM0 and | ||
| // RMX1 should either both be unset (in which case filters are active), or | ||
| // both be unset (in which case all filters are ignored). |
There was a problem hiding this comment.
This appears to be a hangover from the MCP2510 which is no longer (officially) supported by the MCP2515. See https://i.imgur.com/QmthNtj.png vs https://i.imgur.com/sGE2jpq.png
There was a problem hiding this comment.
Thanks for finding this!
I suspect it's just a typo and the intention was to use FLAG_RXM1 on L292 (old).
But at the same time I don't want to change code that I don't fully understand, and didn't spend enough time testing. The PR as-is is already an improvement, and hopefully with the TODO someone else (or future me) will be curious to figure out how to fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MCP2515::setFilterRegisters() to allow setting mask and filter registers
directly, as well as control rollover
This provides a much greater flexibility than just one mask and filter pair.
While at it, fix incorrect REG_RXFn* macros, and add TODOs for a couple more
places in the code related to filtering that seem to violate the datasheet.