Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Literate notebook demonstrating floating capabilities #84

Closed

Conversation

michaelcdevin
Copy link
Contributor

@michaelcdevin michaelcdevin commented Oct 16, 2024

Closes #80

@michaelcdevin
Copy link
Contributor Author

@kevmoor I still need to do a bit of testing and cleanup to make sure things are running properly and appearing in "notebook form" correctly, but feel free to start reviewing the code and language of the notebook itself.

kevmoor
kevmoor previously approved these changes Oct 16, 2024
Copy link
Collaborator

@kevmoor kevmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, and disambiguates the floating capabilities a lot! If you're able to get a paraview image screenshot dropped in, that would be awesome, but not required. Once the docs ci/cd passes, we can merge. Hopefully my comments will resolve the issues preventing the ci/cd from running on this.

# The boundary condition previously was essentially fixing the bottom of the turbine tower in place,
# since it is installed in the ground.
# However, for our floating platform, we want the loads from the topside to propagate to the platform,
# so our restoring hydrodynamics and mooring loads will "constaint" the combined meshes as we want.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"constaint" -> constrain?


# We also will need to specify where the HydroDyn and MoorDyn libraries exist on the computer.
# These will differ based on operating system and system setup, so change these as needed.
hd_lib = "$path/../../bin/HydroDyn_c_binding_x64"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to change these to nothing so it will use the auto installed libraries in the ci/cd environment

import OWENS
import OWENSFEA

path = runpath = splitdir(@__FILE__)[1]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to change this to runpath = path = "/home/runner/work/OWENS.jl/OWENS.jl/examples/literate" so it works within the ci/cd environment. I wasn't ever able to figure out how to get it to work with a relative path.

PyPlot.ylabel("Force [N]")
PyPlot.title("Hydrodynamic Surge Loading")

nothing
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is all great, if we'd be able to visualize the resulting hydrodyn and moordyn and topside vtk outputs with paraview, and drop a screenshot of that here, that might be really cool.

@kevmoor kevmoor mentioned this pull request Oct 17, 2024
@kevmoor kevmoor closed this Oct 17, 2024
@kevmoor
Copy link
Collaborator

kevmoor commented Oct 17, 2024

Closed since switching to PR #86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add literate.jl example for floating case
2 participants