-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multiple phase realizations to waves #297
Conversation
Pull Request Test Coverage Report for Build 7134822091
💛 - Coveralls |
I have updated this PR and it is ready for review. The I am still working on a demonstration of how to determine the number of phase realizations needed. I think it is best to merge this PR to include the functionality in WecOptTool, and I will work on another PR which updates one of the tutorials to demonstrate the multiple phase realizations and a reliable method for determining the number to use. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! just some minor changes. I reviewed the source and tests but not the tutorials.
Description
This PR adds a
realization
dimension to the waves DataArray (Issue #262). The number of realizations is set equal to 1 by default, but is set to 5 for tutorial 3 and 4 which have irregular waves. Thesolve()
function now loops over multiple phase realizations and returns a list of the results from all optimizations.Type of PR
Checklist for PR
Additional details
I am still working on adding a section to one of the tutorials to demonstrate multiple phase realizations vs. a longer time window.